search

yahoo / kubectl-flame

Kubectl plugin for effortless profiling on kubernetes
Apache License 2.0
796 stars 96 forks source link

feat: Support macOS arm64 #87

Open mandrean opened 1 year ago

mandrean commented 1 year ago

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Summary

This PR adds support for darwin/macOS arm64 users. Closes #74 and maybe others.

Description

I tried cross-compiling kubectl-flame with goreleaser on my M1 Mac, but got a compilation error for the darwin-arm64 binary: image

With x/sys bumped it now compiles just fine for darwin-arm64 as well:

image

Which means that the goreleaser GHA action will be able to build & release for that target arch as well, so the .krew.yaml can be updated with the new platform support.

Tombar commented 1 year ago

This works on my machine™

TYVM

mandrean commented 1 year ago

Hi @edeNFed! Could you review this?

mwos-sl commented 1 year ago

Dear yahoo, any chances to merge it and realease? Or should we drive our forks and release processes to have it?

kinoute commented 1 year ago

I second this. An ARM64 version would be nice.