search

yahoo / mdbm

MDBM a very fast memory-mapped key/value store.
BSD 3-Clause "New" or "Revised" License
993 stars 111 forks source link

Update tests for OSX #39

Closed eam closed 9 years ago

yahoocla commented 9 years ago

CLA is valid!

areese commented 9 years ago

looks good to me. It'd be nice to treat it as 3 OSes instead of just linux vs OS-X.

eam commented 9 years ago

There are a few tests that absolutely are linux-only; I figured I'd err on the side of disabling with the assumption that these have mostly been developed for linux. Don't have a FreeBSD box handy to test on, unfortunately.

I'll switch it around to darwin-only excludes.

timrc-git commented 9 years ago

Several thoughts: a) this pretty much clinches that I should add a feature flag to disable windowed-mode b) my apologies for not disabling the robust-lock tests on that feature flag c) if possible, I'd like to pull the makefile differences into Makefile.base Or just unconditionally set DYLD_LIBRARY_PATH, or use RPATH/RUNPATH

I'll take a crack at this later (need to get some other stuff done first).

Thanks! .timrc

eam commented 9 years ago

Oh, of course. I should've wrapped those in HAVE_ROBUST_PTHREADS.

eam commented 9 years ago

I moved the LD_LIB_PATH bits into Makefile.base, commented the reasons for excluding tests and switched to using HAVE_ROBUST_PTHREADS. I think this is ready to go.

timrc-git commented 9 years ago

Thanks Evan!

After I merge this, I plan to add a flag for windowed mode. Hopefully, I can twist your arm to retest then.

eam commented 9 years ago

Absolutely.