search

yahoo / mdbm

MDBM a very fast memory-mapped key/value store.
BSD 3-Clause "New" or "Revised" License
992 stars 111 forks source link

Explicit static_cast<int>() avoids C++11 narrowing error #63

Closed fish2000 closed 8 years ago

fish2000 commented 8 years ago

It was a necessary change to avoid a compilation error about narrowing std::size_t to int when building in C++11 mode from HEAD – after that it built and ran OK

… This PR cross-posted from https://github.com/timrc-git/mdbm/pull/4

yahoocla commented 8 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

fish2000 commented 8 years ago

screen shot 2016-06-25 at 10 23 54 pm

areese commented 8 years ago

@fish2000 We're looking at what is going on with the CLA bot, and once we've figure that out, I'll merge this. Thanks for your contribution. :)

areese commented 8 years ago

👍 Thanks @fish2000 sorry about the spurious cla issue, I've validated you have signed it.

yahoocla commented 8 years ago

CLA is valid!

fish2000 commented 8 years ago

Sweet, glad that worked out! Salud.

timrc-git commented 8 years ago

Thanks for the patch, fish2000! And thanks for resolving this, Allen!