fix a bug that mdbm.first(iter) always return NULL in Java implementation

yahoo / mdbm

MDBM a very fast memory-mapped key/value store.

BSD 3-Clause "New" or "Revised" License

992 stars 111 forks source link

fix a bug that mdbm.first(iter) always return NULL in Java implementation #69

Closed hirkatou closed 7 years ago

hirkatou commented 7 years ago

In java implementation, mdbm.first(iter) and mdbm.next(iter) do not work. They always return NULL.

This PR includes:

fix the bug
fix extra token in jni_helper_defines.h
fix javadoc about first(), next(), firstKey(), nextKey()
add unit tests to test first(), next(), firstKey(), nextKey()

yahoocla commented 7 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

areese commented 7 years ago

Thanks for the PR, this was clearly a terrible oversight on my part. :)