search

yahoo / open_nsfw

Not Suitable for Work (NSFW) classification using deep neural network Caffe models.
BSD 2-Clause "Simplified" License
5.87k stars 1.05k forks source link

Python3 Support #76

Open robputt opened 6 years ago

robputt commented 6 years ago

Hi,

Most modern Linux distributions are packaging python-caffe only for Python3 and hence getting this up and running has been a pain for me, it would be super awesome if the sample script could be made Python3 friendly. I will probably tidy up what I have locally here to fix this and raise a PR.

Best Regards,

Rob

rahiel commented 6 years ago

I have a fork of open_nsfw with Python3 support here: https://github.com/rahiel/open_nsfw--

robputt commented 6 years ago

Awesome I will check it out, but is there any chance to port this back into the upstream repo?

rahiel commented 6 years ago

As far as I can see, this repo is not maintained anymore. There are many pull requests left open. That's why I decided to fork it. This fork also has an additional goal of making it very easy to deploy the model in production.

I can upstream Python3 support if this repo becomes active again.

BenLloydPearson commented 6 years ago

@rahiel, We don't have anyone to maintain this repo anymore, but we're more than happy to hand it off to community members to take on maintainership. Is this something you'd be interested in? Or would you simply be interested in upstreaming python 3 support? I can grant you write access either way.

rahiel commented 6 years ago

Hey @BenLloydPearson, I am interested in maintaining this.

Do you think the HTTP REST interface I made at open_nsfw-- would be a fit for the main open_nsfw project? The benefit of a HTTP interface is that people can use it with any programming language they like.

robputt commented 6 years ago

I think the REST interface is interesting but I'd much prefer it if we could pass a multipart encoded file object, or a URL, something we can easily expand on. I agree we need a new maintainer for this, my main interest in OpenNSFW is for inclusion as a plugin in OpenStack Nemesis, it aims to make a file scanning API which provides intelligence about files. - https://github.com/openstack/nemesis

rahiel commented 6 years ago

I think the REST interface is interesting but I'd much prefer it if we could pass a multipart encoded file object, or a URL, something we can easily expand on. I agree we need a new maintainer for this, my main interest in OpenNSFW is for inclusion as a plugin in OpenStack Nemesis, it aims to make a file scanning API which provides intelligence about files. - https://github.com/openstack/nemesis

Currently you can already pass URLs to the API , I've made an issue for multipart encoded files (1#).

BenLloydPearson commented 6 years ago

@rahiel I invited you to have write access to this repo so you can work on merging improvements. There is currently branch protection on master to require one review before merging PR's. This will allow you to merge other's improvements, and feel free to ping me directly if you need help with reviews for your PR's. If anyone else in this thread is interested in helping with this, please reach out to me.