Fix strings on iOS - Githubissues

yahoo / squidb

SquiDB is a SQLite database library for Android and iOS

https://github.com/yahoo/squidb/wiki

Apache License 2.0

1.31k stars 132 forks source link

Fix strings on iOS #145

Closed sbosley closed 8 years ago

sbosley commented 8 years ago

We had a bug in our iOS port of CursorWindow where we were not correctly converting strings back to UTF-16 the way the native Android implementation does. This PR borrows some more code from AOSP to more exactly mimic the Android behavior (code found in SquidbUnicode.h and SquidbUnicode.m, slightly adapted for our use case).

sbosley commented 8 years ago

I should write a couple unit tests before we merge this.

jdkoren commented 8 years ago

LGTM