search

yahoo / squidb

SquiDB is a SQLite database library for Android and iOS
https://github.com/yahoo/squidb/wiki
Apache License 2.0
1.31k stars 132 forks source link

Add bintray badge #178

Closed jaredsburrows closed 8 years ago

jaredsburrows commented 8 years ago

@sbosley Add bintray's badge

sbosley commented 8 years ago

Oh nice this is cool -- do you think we should make it display the latest stable version rather than the latest beta version though? When I preview the file it shows me a download link for 3.0 beta 1.

jaredsburrows commented 8 years ago

@sbosley Not sure. I just went here: https://bintray.com/yahoo/maven/squidb/view and clicked on the badge and it gave me the markdown.

jaredsburrows commented 8 years ago

@sbosley So what did you decide? I see you have a PR for 3.0 into master. We should be able to add this in.

sbosley commented 8 years ago

@jaredsburrows there's one thing that's still kind of weird-- after I published the 2.1.0 version, the latestVersion link went to that instead of the 3.0 beta version. It seems like it's the latest version by publication date, rather than by version number. Probably not a big deal, but it could be weird if we ever need to backport any fixes to 2.x Do you want to dig in a bit to see if it's possible to make it show the badge for the latest by version number rather than by publication date? If it turns out that's not possible it's no big deal, and we can just live with the possible occasional weirdness in that edge case.

jaredsburrows commented 8 years ago

@sbosley Yeah its an incremental release based on the latest uploaded artifact dates. I am guessing 3.0 will become the new release right? 2.1.0 - 3.0. So once 3.0 is out, it will say 3.0 on the badge.

sbosley commented 8 years ago

@jaredsburrows right, but it would revert back to showing e.g. 2.1.1 if we ever backported fixes to the 2.x branch. I guess though even in that case, we'd probably be likely to release a new 3.x build shortly thereafter, so my earlier objection is moot. Let's do it!

jaredsburrows commented 8 years ago

@sbosley Thanks for explaining. Sounds good!