yahoo / squidb

SquiDB is a SQLite database library for Android and iOS
https://github.com/yahoo/squidb/wiki
Apache License 2.0
1.31k stars 132 forks source link

Evaluate API for per-statement CompileContext flags #231

Open jdkoren opened 7 years ago

jdkoren commented 7 years ago

Consider using flags in the CompileContext to replace some arguments we currently pass around while compiling statements. Excerpt from gitter chat:

Sam Bosley @sbosley 11:25 well I was thinking in version 4.0 it might make sense to fold the boolean withBoundArguments, boolean forSqlValidation arguments into the CompileContext so you could imagine setting such flags on individual statements if you wanted to I'm not wedded to that though, so I could be convinced to change my mind and we could still take it out until that change was made (if it even happens) and then decide again

Jonathan Koren @jdkoren 11:28 I see. That's not a bad thought

Sam Bosley @sbosley 11:29 maybe it makes more sense to take it out now and defer the decision to design a more robust api for setting arbitrary flags on individual statements since I bet the flags use case is more compelling than the argument resolver case, but it's not totally set up for that right now