SquidUtilities.copyDatabase never quite worked correctly. The two major problems were that 1) it never copied the supporting files like the journal or WAL file, meaning if the DB hadn't been checkpointed after a transaction the main file might not have the changes yet, and 2) to be really safe, the exclusive lock should be acquired while copying the file so that no other thread could do anything to the DB while it was being copied. This PR fixes these shortcomings by moving copyDatabase into SquidDatabase itself, deprecating the SquidUtilities version, and ensuring that the method is covered in our test suite.
jdkoren
commented
7 years ago
SquidUtilities.copyDatabase never quite worked correctly. The two major problems were that 1) it never copied the supporting files like the journal or WAL file, meaning if the DB hadn't been checkpointed after a transaction the main file might not have the changes yet, and 2) to be really safe, the exclusive lock should be acquired while copying the file so that no other thread could do anything to the DB while it was being copied. This PR fixes these shortcomings by moving
copyDatabaseinto SquidDatabase itself, deprecating the SquidUtilities version, and ensuring that the method is covered in our test suite.