Don't suppress exceptions from upgrade/downgrade

yahoo / squidb

SquiDB is a SQLite database library for Android and iOS

https://github.com/yahoo/squidb/wiki

Apache License 2.0

1.31k stars 132 forks source link

Don't suppress exceptions from upgrade/downgrade #43

Closed jdkoren closed 9 years ago

jdkoren commented 9 years ago

Fixes Issue #42 (github.com/yahoo/squidb/issues/42)

sbosley commented 9 years ago

This is great. It also could allow users to pass more detailed information about migration failures to themselves if they want to by subclassing MigrationFailedException and throwing it directly from onUpgrade, if we made some minor tweaks to the flow in onUpgrade/onDowngrade. Do you think we could add that and document it as a valid option before we merge?

sbosley commented 9 years ago

LGTM