search

yahoo / storm-yarn

Storm-yarn enables Storm clusters to be deployed into machines managed by Hadoop YARN.
Other
417 stars 161 forks source link

Integration Test w/ Topology Submission #14

Closed anfeng closed 11 years ago

anfeng commented 11 years ago

Include storm-starter within IntegrationTest. We also also verify the submitted topology is actually running per Nimbus Thrift API.

anfeng commented 11 years ago

Please review this pull request.

revans2 commented 11 years ago

The changes look OK to me. I would like to get rid of the sleeps, but I don't see any way currently to do that. I also would like to get rid of the killall call in the tests. Please file an issue for each of these so we can track and fix them and then feel free to merge it in.

anfeng commented 11 years ago

I have remove "killall" by using a different topology (Excalamation Topology) which is pure Java. Let me create issue for sleeeps.

anfeng commented 11 years ago

Issue #15 created for tracking sleep() calls.

anfeng commented 11 years ago

Bobby, please do another review, and we will then merge this pull request.

d2r commented 11 years ago

Andy walked me through the changes. The killall was removed; that was the main concern. +1