Allow JAVA_HOME and yarn classpath to be set via configuration parameter in yaml.

boneill42 commented 10 years ago

Another fix for Issue #50. This one allows the user to set the JAVA_HOME in the yaml instead of relying on environment configuration everywhere.

boneill42 commented 10 years ago

I was hoping we could control the storm cluster from any client machine. The client machines might be configured substantially different than the server machines. (different JAVA_HOME's, different hadoop classpath's, etc.) Feel free to reject this pull request if you feel differently.

(I am now fixing it such that the hadoop classpath can be specified as well.)

anfeng commented 10 years ago

Please send us a CLA form per instruction at https://github.com/yahoo/storm-yarn/wiki/Contributing

From: boneill42 notifications@github.com Reply-To: yahoo/storm-yarn <reply+i-20369211-bfcee9a416311b27ea3bcfe3689b70309e0019c2-2708344@reply.git hub.com> Date: Tuesday, October 1, 2013 6:30 PM To: yahoo/storm-yarn storm-yarn@noreply.github.com Subject: Re: [storm-yarn] Allow JAVA_HOME to be set via configuration parameter in yaml. (#54)

I was hoping we could control the storm cluster from any client machine. The client machines might be configured substantially different than the server machines. (different JAVA_HOME's, different hadoop classpath's, etc.) Feel free to reject this pull request if you feel differently.

(I am now fixing it such that the hadoop classpath can be specified as well.)

‹ Reply to this email directly or view it on GitHub https://github.com/yahoo/storm-yarn/pull/54#issuecomment-25507529 .

boneill42 commented 10 years ago

Signed and submitted.

revans2 commented 10 years ago

The patch looks good to me and I can confirm we got the CLA. I am +1 on the change.

@boneill42

Can you put up a similar pull request for the 0.23 branch?

yahoo / storm-yarn

Allow JAVA_HOME and yarn classpath to be set via configuration parameter in yaml. #54