YCB should not use YUI - Githubissues

yahoo / ycb

A multi-dimensional configuration library that builds bundles from resource files describing a variety of values.

BSD 3-Clause "New" or "Revised" License

67 stars 24 forks source link

YCB should not use YUI #6

Closed caridy closed 11 years ago

caridy commented 11 years ago

YCB, as today, is a server side only component, you can corroborate this by looking at index.js, which uses require. By looking at the code, there are only 3 YUI features used by this:

Y.JSON., which could be replaced with JSON.
Y.Object.values, to iterate, which could be done by just using in
Y.Array.forEach, to iterate, which could be done by just using for

Using YUI on the server, in its current form, is expensive, and in this particular case, it looks like a waste.

caridy commented 11 years ago

After PR #7, YUI is not longer part of the runtime.

Now, next step is to remove it from the test, relying on yuitest instead. more info here: http://yuilibrary.com/yuitest

caridy commented 11 years ago

PR #8 is moving YUI to devDependencies, that's good enough for me.

caridy commented 11 years ago

we are done with this one.