Closed lerouxrgd closed 1 year ago
Hello, I have released V2.0.12 which includes your request. NGTFloat16 in the arguments is just void defined by typedef.
Hello @masajiro ,
Thank you very much, it all looks good for NGT index ! Besides, I have actually realized that similar functions would be required for QBG index too, I will open a new issue for that.
Hello,
In
ngt-rs
I am now trying to enforce index type at compile time, which would look like that:NgtIndex<f32>
,NgtIndex<u8>
orNgtIndex<f16>
.Therefore, the
insert
method would need to be templated to take aVec<T>
instead ofVec<f32>
. Currently thengt-rs
wrapper enforcesf32
usage (even ifNgtObjectType
is something else likeu8
orf16
) because under the hood it usesngt_insert_index_as_float
from the C API.Would it be possible to have the following methods added to the C API:
So that
ngt-rs
wrapper could leverage them for better indexes.