search

yahoojapan / athenz-client-sidecar

Moved to https://github.com/AthenZ/athenz-client-sidecar
https://github.com/AthenZ/athenz-client-sidecar
Apache License 2.0
15 stars 5 forks source link

[minor] add service cert endpoint #31

Closed WindzCUHK closed 4 years ago

WindzCUHK commented 4 years ago

as title

codecov-io commented 4 years ago

Codecov Report

Merging #31 into master will increase coverage by 0.91%. The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   89.66%   90.57%   +0.91%     
==========================================
  Files          11       12       +1     
  Lines         648      881     +233     
==========================================
+ Hits          581      798     +217     
- Misses         56       65       +9     
- Partials       11       18       +7
Impacted Files Coverage Δ
config/config.go 88.23% <ø> (ø) :arrow_up:
service/role.go 94.41% <100%> (ø) :arrow_up:
router/routes.go 100% <100%> (ø) :arrow_up:
handler/handlers.go 100% <100%> (ø) :arrow_up:
router/router.go 95.65% <100%> (ø) :arrow_up:
usecase/tenantd.go 93.22% <90.9%> (-2.02%) :arrow_down:
service/svccert.go 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f50efd1...594f91a. Read the comment docs.

WindzCUHK commented 4 years ago

fix done: https://github.com/yahoojapan/athenz-client-sidecar/pull/31/files/aeb59366a91b99bf67cebfed9cf37551c909e06a..9c647b16fe6abb008ca844b199de9014741d0f4f

kevindiu commented 4 years ago

LGTM