search

yahoojapan / athenz-client-sidecar

Moved to https://github.com/AthenZ/athenz-client-sidecar
https://github.com/AthenZ/athenz-client-sidecar
Apache License 2.0
15 stars 5 forks source link

struct/interface naming convention #36

Closed kyfujisa closed 1 year ago

kyfujisa commented 4 years ago

Change to the following naming convention. Do the same for access token code. -> RoleTokenService https://github.com/yahoojapan/athenz-client-sidecar/blob/3ceaeb900f4862d62807cd8bdb15172242236e5e/service/role.go#L44

-> roleTokenService https://github.com/yahoojapan/athenz-client-sidecar/blob/3ceaeb900f4862d62807cd8bdb15172242236e5e/service/role.go#L51

-> RoleTokenResponse( Imitate this: https://github.com/yahoojapan/athenz-client-sidecar/blob/master/service/role.go#L76 ) https://github.com/yahoojapan/athenz-client-sidecar/blob/3ceaeb900f4862d62807cd8bdb15172242236e5e/service/role.go#L76

WindzCUHK commented 4 years ago

Also,

  1. RoleProvider => RoleTokenProvider https://github.com/yahoojapan/athenz-client-sidecar/blob/3ceaeb900f4862d62807cd8bdb15172242236e5e/service/role.go#L82

  2. StartRoleUpdater => StartUpdater, RefreshRoleTokenCache => RefreshCache, GetRoleProvider => GetProvider https://github.com/yahoojapan/athenz-client-sidecar/blob/3ceaeb900f4862d62807cd8bdb15172242236e5e/service/role.go#L44-L48

WindzCUHK commented 1 year ago

continue in: https://github.com/AthenZ/athenz-client-sidecar/issues/5