Inconsistency in handling Athenz CA config - Githubissues

yahoojapan / athenz-client-sidecar

Moved to https://github.com/AthenZ/athenz-client-sidecar

https://github.com/AthenZ/athenz-client-sidecar

Apache License 2.0

15 stars 5 forks source link

Inconsistency in handling Athenz CA config #43

Closed WindzCUHK closed 1 year ago

WindzCUHK commented 4 years ago

issue

Error is not print on invalid config.
- https://github.com/yahoojapan/athenz-client-sidecar/blob/1e6172aa15c7e4f1b67bc243b76c33e781c28ceb/service/role.go#L153-L164
- https://github.com/yahoojapan/athenz-client-sidecar/blob/1e6172aa15c7e4f1b67bc243b76c33e781c28ceb/service/access.go#L144-L155
New fails on invalid config.
- https://github.com/yahoojapan/athenz-client-sidecar/blob/1e6172aa15c7e4f1b67bc243b76c33e781c28ceb/service/svccert.go#L302-L313

suggestion

on error, print error log but ignore the error (i.e. use default CA).

WindzCUHK commented 1 year ago

continue in: https://github.com/AthenZ/athenz-client-sidecar/issues/6