search

yahoojapan / authorization-proxy

Moved to https://github.com/AthenZ/authorization-proxy
https://github.com/AthenZ/authorization-proxy
Apache License 2.0
35 stars 9 forks source link

configuration name is not consistency #44

Closed kevindiu closed 4 years ago

kevindiu commented 4 years ago

Configuration name should be _ separated or by letter case?

https://github.com/yahoojapan/authorization-proxy/blob/1360c02583f954790106fb51f367723d4d034239/config/config.go#L63

https://github.com/yahoojapan/authorization-proxy/blob/1360c02583f954790106fb51f367723d4d034239/config/config.go#L137

WindzCUHK commented 4 years ago

related: https://github.com/yahoojapan/athenz-client-sidecar/issues/34#issue-571814316

roletoken => role_token https://github.com/yahoojapan/authorization-proxy/blob/e500d8c4977c83821434199f6d5001b815a86b4a/config/config.go#L172-L173