Closed WindzCUHK closed 4 years ago
@WindzCUHK
(Perhaps out of the scope of this ticket, but) It's better to add a filed to allow configuration to change from Authorization: Bearer
like other headers.(Although using another header name than Authorization: Bearer
is against the standard.)
https://github.com/yahoojapan/authorization-proxy/blob/745655002bae0ca52b8ab8a0d937691332019aff/config/config.go#L214-L233
@tatyano
It's better to add a filed to allow configuration to change from Authorization: Bearer like other headers.
created an issue: https://github.com/yahoojapan/athenz-authorizer/issues/68
Merging #64 into master will increase coverage by
0.64%
. The diff coverage is98.85%
.
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 87.02% 87.66% +0.64%
==========================================
Files 14 14
Lines 655 689 +34
==========================================
+ Hits 570 604 +34
Misses 75 75
Partials 10 10
Impacted Files | Coverage Δ | |
---|---|---|
config/config.go | 100.00% <ø> (ø) |
|
handler/handler.go | 92.85% <ø> (ø) |
|
service/option.go | 100.00% <ø> (ø) |
|
main.go | 56.84% <96.29%> (+10.78%) |
:arrow_up: |
handler/transport.go | 100.00% <100.00%> (ø) |
|
router/debug_router.go | 95.65% <100.00%> (ø) |
|
router/debug_routes.go | 88.88% <100.00%> (ø) |
|
service/server.go | 97.63% <100.00%> (ø) |
|
service/tls.go | 78.37% <100.00%> (-0.57%) |
:arrow_down: |
usecase/authz_proxyd.go | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b6988bf...7ab155b. Read the comment docs.
It looks like there's something in this file that needs to be fixed.
It looks like there's something in this file that needs to be fixed.
fixed in: 19004f9
Description
TODO
v2.0.0
changes
config.go
.v2.0.0
/test/data
SA1019: t.BuildNameToCertificate is deprecated: NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates. (staticcheck)
https://github.com/yahoojapan/authorization-proxy/blob/20ac59579566b5b19719f6b043ca962762c99819/test/data/example_config.yaml#L1-L69
Details
Suggested naming convention rules:
camelCase
in yamlduration
in the commentexpiry
,period
,delay
,duration
time
enable
prefixs
suffixRemarks
ETag
,Etag
andetag
in docs.ETag
as constantETag
as constantduration
Type of change
Flags
Related issue/PR
Checklist
[major]
/[minor]
/[patch]
/[skip]
in the PR titleChecklist for maintainer
Squash and merge
[major]
/[minor]
/[patch]
/[skip]