kyfujisa commented 4 years ago

Description

This is a PR to import fixes for bugs related to regular expressions.

TODO:

[x] merge this
- https://github.com/yahoojapan/athenz-authorizer/pull/73
[x] update go.mod

Type of change

[x] Bug fix
[ ] New feature
[ ] Refactoring (no functional changes, no api changes)
[x] Non-code changes (update documentation, pipeline, etc.)

Flags

[x] breaks backward compatibility
[x] requires a documentation update
[ ] has untestable code

Related issue/PR

PR purpose is to import this PR modification.
- https://github.com/yahoojapan/athenz-authorizer/pull/73

Checklist

[x] Followed the guidelines in the CONTRIBUTING document
[x] Added prefix [major]/[minor]/[patch]/[skip] in the PR title
[x] Tested and linted the code
[x] Commented the code
[x] Made corresponding changes to the documentation
[x] Confirmed no dropping in test coverage (by Codecov)
[x] Passed all pipeline checking
[x] Approved by >1 reviewer

Checklist for maintainer

[ ] Use Squash and merge
[ ] Double-confirm the merge message has prefix [major]/[minor]/[patch]/[skip]
[ ] Delete the branch after merge

codecov-commenter commented 4 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files          15       15           
  Lines         740      740           
=======================================
  Hits          643      643           
  Misses         87       87           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1466a68...887d7ab. Read the comment docs.

WindzCUHK commented 4 years ago

Please also update this doc. https://github.com/yahoojapan/authorization-proxy/blob/master/docs/debug.md

kyfujisa commented 4 years ago

@WindzCUHK Is this not enough? 6d72953

yahoojapan / authorization-proxy

[minor] Fix regex bug #68