yairEO / photobox

A lightweight CSS3 image viewer that is pretty to look and and easy to use
GNU Affero General Public License v3.0
750 stars 280 forks source link

Non-functional on Safari #66

Closed KodeKreachor closed 10 years ago

KodeKreachor commented 10 years ago

Hello, this is a nice plugin. Unfortunately it doesn't work on the latest version of Safari. Any plans to update it to work with Safari?

yairEO commented 10 years ago

hey, well last checked it worked pretty well on Safari (but checked on an iPad). I don't have access to a mac nor do I know anyone who owns a mac so it's kinda hard to test (and I don't own a license to browserstack). Anyway, please check my website where it works on production and let me know - www.gurushots.com

KodeKreachor commented 10 years ago

Thanks for getting back to me. Let me say once more, this is a really great plugin!! :)

I too don't own a mac, I actually installed Safari on my PC and tested the following site and noticed that the plugin doesn't come up: http://dropthebit.com/demos/photobox/

It looks like it does work on the gurushots.com website

yairEO commented 10 years ago

You cannot install Safari on windows, since Safari for windows does not exist. What you installed was in fact an old and deprecated version found on the internet (dated 2012) and of course, very buggy and experimental browser which development for has been abandoned.

KodeKreachor commented 10 years ago

Interesting, I'd assume they would have removed the download link: http://support.apple.com/kb/dl1531

Regardless, I have used a friends mac and it does not work with the plugin

yairEO commented 10 years ago

it's weird because this plugin runs on several major websites and millions are exposed to it daily. what is the js error you get, would you at least say that instead of generally saying "it doesn't work" ?

KodeKreachor commented 10 years ago

I apologize, please don't take my feedback personally, I admire your work very much and am only trying to help make it even better.

When I pull up the dropthebit site in a Safari browser I don't see any errors present, nor do I see any in the developer error console, only a blank screen when I click on one of the thumbnails, please see here: http://c4.staticflickr.com/4/3932/15599671881_f914a0b85a_z.jpg

yairEO commented 10 years ago

I'm not sure the demo page has been updated in a while, but I assure you, it does work on Safari. if you know CSS you can poke around with the developer tools of Safari and see why it is not showed on your machine (it's in an #overlay element appended to the body )

KodeKreachor commented 10 years ago

Thank you, I do know CSS/HTML/JS quite well and I've poked around quite a bit, but I suspect it may have to do with the code that actually pulls back and renders the selected image, along with the arrow controls, thumbnails, play & exit buttons.

Also, just a bit more information for you, I noticed that in Safari, it's rendering a base 64 encoded url for the selected image: http://c4.staticflickr.com/4/3953/15416868360_9d9e2021f3_z.jpg

Where as in Chrome, it's a standard url: http://c2.staticflickr.com/4/3954/15603302002_151534b982_z.jpg

sardbaba commented 10 years ago

Hi yair, I'm experiencing the same problem described by KK so I think that this issue should be re-opened. The full image is not loaded on Safari (my test is on v5.1.10) untill you try to zoom with the mouse or the trackpad; then the image is loaded but there are two errors:

1) TypeError: 'undefined' is not an object (evaluating 'imageLinks[lastActive].rel') - at row 762 2) TypeError: 'undefined' is not an object (evaluating 'out.off') - at row 778

Hope you can help us

Cheers and thank you for this great work.

sardbaba commented 10 years ago

Errors 1) and 2) seems to be solved with:

if ( !firstTime && typeof( imageLinks[lastActive].rel ) != 'undefined' && imageLinks[lastActive].rel == 'video' ) {

Anyway this does not solve the main issue on Safari.

KodeKreachor commented 10 years ago

Thanks for the post @sardbaba , I'm still experiencing this issue as well.

yairEO commented 10 years ago

I'm trying to find someone with a Mac so I could debug this.

yairEO commented 10 years ago

Ok, just checked it on a MAC on Safari 6.2 and everything works well. I guess you guys are using old browser versions, I suspect older than a year even. Since nobody here cared to say on which OS/browser version they have found it to be problematic I have no choice but to ignore this issue. please make sure your machines are updated...

sardbaba commented 10 years ago

Sorry, I wrote my browser version instead. Here is the full stuff: safari v5.1.10 on mac book pro with snow leopard. I can't upgrade safari because i can't upgrade OS (there are many issues between mac pro 2011 and last OS).

yairEO commented 10 years ago

I see...well this is yet another reason why windows owns mac. on windows you are the master of your machine. on Mac you are a slave to it's mercy...I will try to research how to downgrade my Safari (if that's even possible on idiotic mac) and see how this could be resolved.

KodeKreachor commented 10 years ago

I'm using the latest version offered on Apple's official link (also posted that 9 days ago): http://support.apple.com/kb/dl1531

yairEO commented 10 years ago

@KodeKreachor - the link you have provided is for windows, not mac), therefor irrelevant

yairEO commented 10 years ago

I already told you, Safari is NOT supported on windows, nothing works there, it is you who is tiring me, not the other way man. I work on 10 different projects, I will most certainly won't use my free time trying to fix an unsupported browser from 2012 whom apple abandoned. or maybe it will satisfy your rage if I will leave everything I'm doing right now and focus on that? I want to fix this bug as much as you do, but you are mixing things up. This discussion is about MAC OS with Safari below version 6 causing issues. I already spent half my day trying to install Mac OS on a virtual machine, which worked and now the other guy here said this issue only happens on older version, so I have to download and yet again install Mac OS and re-try, which will take more hours, not to mention I have endless work on other projects plus my real full-time job..and people on Github which are tired from my attitude after months of development and releasing this shit for free..

KodeKreachor commented 10 years ago

I will say again that you do wonderful work, and we all appreciate it very much. My advice would be to place a disclaimer stating that only modern versions of Safari are supported, regardless of OS. Then after that, step away from the keyboard and have a beer ;) Seriously though man, didn't mean to upset you, keep up the good work!

sardbaba commented 10 years ago

@yairEO - I know what you say about working on different projects and your free time :) And for that I really appreciate the effort you put on this work. You can see your plugin (in which I've added some modifications) in action here: http://www.sardegnaartigianato.com (click on a pic on the main slider) - It lacks some features (like language switcher and some more things) that we are putting on these days but is right now fully functional. Anyway, if you can't work on it feel free to leave this closed, I'll try to check what happens and I'll let you know.

yairEO commented 10 years ago

I've tried with virtual machine but it didn't report any issued to the developer console. I guess something isn't working because it's not a "real" machine. Sorry but I just don't know anyone with a Mac to test on, and especially not a specific OS version with specific Safari...