search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.07k stars 1.51k forks source link

"This Promotion is free" not accessible without excess XP #10054

Open SpacedOutChicken opened 10 months ago

SpacedOutChicken commented 10 months ago

Windows 10, Itch.io version 4.8.1

A promotion with "This Promotion is free" can't be selected unless you have enough XP to select a promotion. The free promotion can be selected without costing XP, so that's all good, but it only comes up as an option when you have XP to spend.

This mod contains a little free promotion, compatible with the base game. Since it's free, can it be made accessible at any time, even without enough XP for a regular promotion? FreePromotionTest.zip

SeventhM commented 10 months ago

I'mma pretend I didn't see this for now. That said imo

  1. Premature optimization, but checking for that is likely non trivial. We would have to build a list of promotions each time instead of lazily checking if we have enough xp. This is especially true for players, rather than the AI. Again, probably premature optimization, but imo it is worth at least mentioning
  2. I think we'd at least need a conditional for if a unit can promote/if a unit has x amount of xp in case this behavior is actually wanted
github-actions[bot] commented 3 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

SeventhM commented 3 months ago

Setting as "will not stale" for now as a known issue, though, I do want to give my perspective here: I don't believe that a unique that doesn't cost xp/doesn't increase the price of later promotions should also inherently als o have the promotion not need xp to be gotten. These seems like different uniques that should exist. Perhaps the problem here is wording

One of these days I might get around to this... maybe. Thinking about it now, maybe this might be something that should be 3 uniques, not just 2. Idk