City names in field improvements are displayed incorrectly in the German translation

[TheKingOfLight]

Platform Linux Mint 21.2, 4.8.14, 64bit.

Version From Flathub, Build 924

Describe the bug When I create a field improvement, the menu shows "- [city name](dir)".

To Reproduce Steps to reproduce the behavior:

1. start a game
2. have the game in German
3. choose a worker and select Build Field Improvement
4. the "code" instead of the city name is displayed

Expected behavior Instead of this code, the corresponding city name should be displayed and a "link" to the city.

Screenshots

Additional context Happens in all multiplayer games Tested in single player and multiplayer

Another problem that might have something to do with it: The icon for guilds is not displayed in German (as shown in the screenshot).

[SomeTroglodyte]

Bad translation: Tile owned by [civName] (You) = Feld im Besitz von [civName] - [cityName] (dir) Surprise: We have a check ensuring placeholders left to right match up, but not the other way 'round?

[SomeTroglodyte]

OK, if I push a unit test for that, the PR will fail its checks unless I also remove all failing translations...

Extra placeholder `[새 게임]` in `Korean` for entry `To create a multiplayer game, check the 'multiplayer' toggle in the New Game screen, and for each human player insert that player's user ID.`
Extra placeholder `[amount]` in `Indonesian` for entry `An enemy [unit] was destroyed while attacking [cityName]`
Extra placeholder `[amount2]` in `Indonesian` for entry `An enemy [unit] was destroyed while attacking [cityName]`
Extra placeholder `[cityName]` in `German` for entry `Tile owned by [civName] (You)`
Extra placeholder `[relAmount]` in `Vietnamese` for entry `Population loss from nuclear attacks [relativeAmount]% [cityFilter]`
Extra placeholder `[...]` in `Hungarian` for entry `'The art of war teaches us to rely not on the likelihood of the enemy's not attacking, but rather on the fact that we have made our position unassailable.' - Sun Tzu`
Extra placeholder `[...]` in `Hungarian` for entry `'The ancient Oracle said that I was the wisest of all the Greeks. It is because I alone, of all the Greeks, know that I know nothing' - Socrates`
Extra placeholder `[...]` in `Hungarian` for entry `'Architecture has recorded the great ideas of the human race. Not only every religious symbol, but every human thought has its page in that vast book.' - Victor Hugo`
Extra placeholder `[...]` in `Hungarian` for entry `'Bushido is realized in the presence of death. This means choosing death whenever there is a choice between life and death. There is no other reasoning.' - Yamamoto Tsunetomo`
Extra placeholder `[tvenkinio]` in `Lithuanian` for entry `'Don't clap too hard - it's a very old building.' - John Osbourne`

Some of these seem to be stylistic choice - e.g. Korean for To create a multiplayer game... So what to do... (I love that Lithuanian """translation""" for the Tower of Pisa quote: No relation to the source quote at all, it's a Bible quote about a bunch of people squashed by a falling tower... )

[SomeTroglodyte]

And the Guilds icon:

... I don't believe you were dreaming, there must be a specific sequence of actions to get the Image cache out of sync... Would be super helpful if you could find it. I suspect downloading mods, checking mods in Options, and/or switching base rulesets back and forth in new game might be involved.

Linut 21.2

I know what you mean - so - kudos for a good, if a bit annoying choice. The new mouse cursors - :vomiting_face:

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

[SeventhM]

Closed as solved