yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.39k stars 1.57k forks source link

"[stats]" is valid for Terrain but for not TileResource #10387

Open AutumnPizazz opened 11 months ago

AutumnPizazz commented 11 months ago

There's pretext #10320 and #10351

image image Terrain's "[stats] " works well.

image image But TileResource's not.

SeventhM commented 11 months ago

Known and noted when I enabled the unique for terrain. Technically, resources all give their effects globally if you have 1 copy of them. This would mean if a mod previously had a "[stats]" unique to take advantage of this rule, adding the functionality to increase its stats on the map as well may be unintended. Likewise, creating an exception for this unique for global effects maybe be unintended for these mods. I'll need to look into this situation a bit more before I add in TileResource functionality

yairm210 commented 11 months ago

Resources give their effects globally? I don't remember that

SeventhM commented 11 months ago

Key example: marble giving a global production increase for wonders, similar to civ 5. See here

yairm210 commented 11 months ago

Oh, you mean resource uniques apply globally, 👍

SomeTroglodyte commented 11 months ago

In other words, there's no Unique duplicating improvementStats, but someone wants Conditional support for those? Edit: Oops, not quite. I'd wildly guess the intention is doable by switching to a terrain target using the resource as filter???

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

SeventhM commented 6 months ago

I'd wildly guess the intention is doable by switching to a terrain target using the resource as filter???

Then the unique wouldn't be on the resource itself. You'd need a separate unique to cover this