yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.46k stars 1.57k forks source link

Feature request: better contrast between resource logos #10497

Closed Cwpute closed 6 months ago

Cwpute commented 11 months ago

Is your feature request related to a problem? Please describe. unciv icons I am colourblind, and sometimes i wish i could distinguish the resource logos better, especially between Gold, Population, and Food. They all have icons which makes them distinct, and of course you end up infering which is which depending on the terrain and building on top, but still, for players discovering the game, quick visualisation, or more surprizing scenarios, having better coulour differenciation will help.

Describe the solution you'd like I fiddled a bit with the colours of the logos. First i went for Food logo, but it didn't work well. Quickly i switched to working on the Population logo: unciv icons test2 … that's right, a simple colour swap between the Population icon and its background. If this one changes, it means you'd have to also change the "empty hex logo" when nobody is exploiting a tile. I'd argue no logo at all would also work, or the same one with transparency applied. But extra work still.

I realized midway through that what mattered the most was differenciating Food and Gold directly on the map. So i tried my hand on the Gold logo: unciv icons test4 It still is a swap between background and icon, but i put more contrast between the two, which i think strikes a good balance.

Describe alternatives you've considered Just for a test, i combined two variations of the Population and Gold logos, and i think it looks good too. unciv icons test5

Additional context There are many colourblind variations, i personally don't see red as vivid as most describe it, and i sometimes mix up light green and yellow (hence this suggestion). If anyone else having colourblindness can give their own input on the matter, you're welcome!

SomeTroglodyte commented 11 months ago

This is a case for - a Mod, trara! I think everything needed exists. There's also "source" Gimp files for these in ImagesToNotAddToGame (#4961) so you can create versions without extra quality loss, and still layered so you can tweak colors more easily.

As for the process how to use these gimps - obviously you'll need to scale, export, undo the scale, once for StatIcons once for EmojiIcons - but how exactly? Some 5% transparent border so texturepacker soesn't touch antialiasing is already included, but... Ah - I dropped that in #4954: I used "NoHalo" scaling. You could also try whether linear looks better...

Cwpute commented 11 months ago

Doesn't it fall within the accessibility features rather than mods ? What makes it more fit for a mod than an included base feature ? And even without talking about accessibility, wouldn't it profit to everybody having better contrasted logos ?

yairm210 commented 11 months ago

The middle gold icon looks very bad, but the second version of the gold/population look good Can you provide those as files so we can poll this on Discord?

SomeTroglodyte commented 11 months ago

Am currently looking to fix the map overlay toggles (see #10491) which are currently based on these icons: image, with "worked" and "yield" reusing Population and Food - I did them, but without noticing the circle colours aren't equal (pop: 00ff21, food: 38ff70. And neither to Gdx GREEN (00ff00) which is layered as circle behind the other two for movement arrows and resource icon display)...

And these are toggle buttons, shown next to each other, which means using the two green ones from your last mockup will look ugly.These two buttons will get inner color black like the top and bottom one, so it's probably fine?

Cwpute commented 11 months ago

@yairm210 I just cropped them out of the original picture. Please also show them as included in the ressources wheel like i showcased them above, because it's not by themselves that they caused problems, but next to other logos. gold2 pop1 Finally, the gold logo you like, next to the other original logos gold1 unciv icons test3

Cwpute commented 11 months ago

And these are toggle buttons, shown next to each other […].These two buttons will get inner color black like the top and bottom one, so it's probably fine?

How, when ? i don't remember Gold being toggleable anywhere 🤔 And saying "fine", do you meun these ones won.t need to change ? for the sake of continuity they'll have to, if such a coloir change is accepted.

which means using the two green ones from your last mockup will look ugly

Oh, green. woops. As i said: colourblind 🙃 Conisider the green background to be, err… dark yellow ? some kind of desaturated orange maybe ?

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] commented 6 months ago

This issue was closed because it has been stalled for 5 days with no activity.