yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.5k stars 1.58k forks source link

Progress bar or blocker when downloading mod list. #10904

Closed Caballero-Arepa closed 9 months ago

Caballero-Arepa commented 10 months ago

Before creating

Problem Description

I'm always annoyed when I want to go and search a mod with the search bar, and when I click enter, apparently the mod list hasn't finished downloading. image

Related Issue Links

No response

Desired Solution

Display a loading bar, or perhaps more simple, a pop-up that tells you that the mod list is loading and to sit down and be quiet, but immediately upon opening the Mod Manager, not upon doing an action.

Alternative Approaches

Or don't display the mod list that has been downloaded. Only show the mod list when it has finished.

Additional Context

It's very late at night, I'm so uncivilized rn

SomeTroglodyte commented 10 months ago

I know. That message was a kludge to address an immediate problem quickly and was never meant to stay. The LoadingImage widget from #10262 was to go in here too...

SomeTroglodyte commented 10 months ago

Fitting the indicator inside the header row it could look like this:

![image](https://github.com/yairm210/Unciv/assets/63000004/ef977ddb-bc67-4e7b-96a0-fb659cf7312c)

... or should I make it a giant one centered over the horizontal separator and almost reaching the top?

![image](https://github.com/yairm210/Unciv/assets/63000004/2bb4e4ed-01a1-47a5-b590-2ca5a4dee474) (oops my math is off target)
Caballero-Arepa commented 9 months ago

Nah I think the small one is good

Caballero-Arepa commented 9 months ago

Thank you very much