yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.49k stars 1.57k forks source link

Feature request: highlight the currently selected policy #11026

Closed BinTianqi closed 7 months ago

BinTianqi commented 9 months ago

Before creating

Problem Description

In the policy panel

The currently selected policy is not highlighted, and players can only know the currently selected policy through the details bar below

Screenshot_20240127-141136_Unciv

Related Issue Links

No response

Desired Solution

Highlighting the selected policy allows players to clearly know what they are doing

Alternative Approaches

There's nothing to say

Additional Context

No response

SomeTroglodyte commented 9 months ago

There's nothing to say

Curse we all live with...

But - I believe there was code to highlight. At least when you do have points or a freebie to adopt a new one, it highlights adoptable ones? No?

SomeTroglodyte commented 9 months ago

The code in question is here. As I said, selection only changes visuals for pickable policies.

To improve -

SomeTroglodyte commented 9 months ago

@BinTianqi if you can run unreleased code, you might help out? See the linked PR - I could supply a jar and/or apk[^1] for that branch, and then you could follow the PR's instructions and start modding the policy picker screen...

[^1]: debug apk's are debug-signed and therefore incompatible with any non-debug release - switching needs an uninstall with data loss. As is usual in the Android world.

BinTianqi commented 9 months ago

I built the code in this branch: https://github.com/SomeTroglodyte/Unciv/tree/PolicyPickerSkinnable , added PolicyColors.zip mod (in PR #11050) to the game , and ran the game with no problem.
studio64_pmwlNYW952 I'm trying to follow the PR's instructions and modify the policy picker screen.

SomeTroglodyte commented 7 months ago

Well, did you arrive at a styling that would be better as default for everybody?

BinTianqi commented 7 months ago

This is too difficult for me.

I set a noticeable color in PolicyColors.json and PolicyColorsDefault.json

ResizedImage_2024-03-06_18-24-26_1346.png

But no effect

ResizedImage_2024-03-06_18-16-57_3172.png

(Android14, Unciv 4.10.16)