Closed SpacedOutChicken closed 8 months ago
Same with sleep I noticed recently. Upgrade should "wake up" any unit, and likely even clear all orders except automation?? I remember - was that earlier Unciv of Civ4? - that even if the new unit can fortify you had to re-fortify. Even promoting IMHO should wake up and thus force you to have 2 turns with reduced fortification bonus?
Not sure if units upgrading should cause wakeup in any case. Promoting - definitely no.
Not sure if units upgrading should cause wakeup in any case
Pretty sure it did in the original Civs I played - up to IV. Also, easiest solution for upgrade changing the ability to fortify (how tempting that word to introduce a typo is).
This ddg hit pretty much corroborates Civ5 does wake up too: https://forums.civfanatics.com/threads/civ-5-unit-upgrades.354720/
Since that link I cited pretty much disparaged the original's wakeup...
Wrong save up there - we need the state before the upgrade to test!
That larger patch boils down to if (newUnit.isFortified() && !newUnit.canFortify(ignoreAlreadyFortified = true)) wake up!
- meaning chooses the least intrusive of the above discussion. The rest is "WTF is there an UnitUpgradeManager that does not actually manage an upgrade?", and one "redundant if" warning workaround. There's four more such warnings in MapUnit, all could copy that approach...
OK, that patch tests out fine. Sleeping artillery stays asleep on upgrade, fortified anti-tank-thingys wake up when helicopterized, fortified musketmen re-fortify from zero "automatically".
But - where did that upgrade several steps all the way to the most modern one go? Must have missed or forgotten some aspects of those multi-upgrade-to unique PR's. Is a rule change unless we re-offer the one-step in the right-click menu... Anyone can provide a multi-upgrade-path mod and save to test that on?
Is there an existing issue for this?
Game Version
4.10.11
Describe the bug
When a unit that can fortify upgrades to a unit that can't fortify (such as upgrading from anti-tank gun to helicopter gunship) the unit will stay fortified, even though the new unit should now no longer be able to fortify.
Steps to Reproduce
Screenshots
Link to save file
FortifiedHelicopter.txt
Operating System
Windows
Additional Information
No response