yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.26k stars 1.55k forks source link

Unciv Wiki Page: Mod File Structure - Uniques Page is broken on the Unciv Wiki #11183

Closed ClementineAccount closed 6 months ago

ClementineAccount commented 6 months ago

Is there an existing issue for this?

Describe the bug

The webpage for Mod File Structures: Unique is broken. https://yairm210.github.io/Unciv/Modders/Mod-file-structure/uniques

I looked around and don't know if I should be using the Issues page to report bugs with the wiki itself but I will document it here in the meantime. I had verified that it was not only on my machine as another friend had the same issue. I had searched for 'Unique' in Issues but did not find an existing issue.

Unsure if it is related to: #11176

Empty string passed to getElementById(). [uniques:1151:29](https://yairm210.github.io/Unciv/Modders/Mod-file-structure/uniques)
Loading failed for the <script> with source “https://yairm210.github.io/assets/javascripts/bundle.8fd75fb4.min.js”.

Steps to Reproduce

  1. Go to https://yairm210.github.io/Unciv/Modders/Mod-file-structure/uniques

Edit: Actual issue is that https://yairm210.github.io/Unciv/Modders/Mod-file-structure/2-Civilization-related-JSON-files/#techsjson contains the wrong link (see latest comment)

Screenshots

image

image

Operating System

Windows

Additional Information

Firefox: 122.0.1 (64-bit) on Windows 11 Arc

ClementineAccount commented 6 months ago

This should be labelled as Documentation too.

SeventhM commented 6 months ago

Works fine for me. Can't reproduce. Actually, that's a lie, I can reproduce but only in browsers that have just opened that haven't refreshed yet. Have you tried refreshing the page?

SeventhM commented 6 months ago

Wait nevermind. I'm dumb, I should've noticed... You have the wrong link. Please go to https://yairm210.github.io/Unciv/Modders/uniques/ as the page moved recently

yairm210 commented 6 months ago

How did you get this link? Maybe we have a broken link somewhere else?

ClementineAccount commented 6 months ago

How did you get this link? Maybe we have a broken link somewhere else?

Ah yes! I found it from: https://yairm210.github.io/Unciv/Modders/Mod-file-structure/2-Civilization-related-JSON-files/#techsjson

image

yairm210 commented 6 months ago

Thanks! Looks like that was a problem with all the files that moved to the subfolder, should be fixed now 👍🏿