Re: Stale issues and PRs

[SeventhM]

Before creating

• [X] This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
• [X] This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in https://github.com/yairm210/Unciv/issues/4697

Problem Description

It seems Yairm added a new GitHub action to label and close older stale Issues and PRs. While I do think there is merit here, I also feel that there likely should be some discussion on some of these to have their labels removed. I'm making this issue here given the large amount of issues that got affected all at once, though perhaps this discussion could take place in each individual issue in the future. I'm also writing this issue because the action made it more difficult to look through issues by recently updated, which is how I usually check for stuff

Issues regarding popular requests or known issues left to solve

• 6956

• 9487

• 5751

• 7791 (should be requested in #3242)

• 7067 (Idk if fixed)

• 7135, #7143

• 7160

• 7183

• 7376

• 7610 (Roadmap featured in pinned PR)

• 7670, #11313 (wontfix?)

• 7745

• 8108

• 9253

• 9315 (Info easy to miss imo)

• 9396 (Idk how it works in Civ V)

• 9697

• 9817

• 9902 (Needs Civ V confirmation)

• 9928

• 9947

• 10070

• 10060

• 10100

• 10543

• 10255, #11229

• 10375 (Known bug: images of mods disappear when reloading the same mod)

• 10387

• 10410 (wontfix?)

• 10457 (Much better than before. Can close?)

• 10509

• 10511

• 10516, #10581, #11264

• 10577 (Missing Civ V feature)

• 10701

• 10576

• 10809

• 10963

Work in progress PRs/Issues

• 9633

• 1236 (Should close and open new issue?)

• 6394, #10254

• 8817, #9497, #9625

• 9419

• 9957

• 10588 (PR is mostly blank, can close)

• 10651 (Stale; most of the work has been in other PRs. Also, I'm personally against)

• 11305

Issues regarding subjects still in discussion

• 7297

• 9132 (Should probably be closed if no one is working on it)

• 10710 (Possible to close?)

• 3417 (Should probably get moved to a new issue)

• 5674

• 6522

• 5856 (Broken images and OP should maybe be updated. Otherwise imo close)

• 6955

• 7632

• 8935 (wontfix? Still kinda annoyed on this one for the use in a unique, and in some civopediaText, but I'm fine with closing)

• 9085

• 9105 (Can close?)

• 9205

• 9240

• 9254 (Pics please)

• 9342

• 9359

• 9399

• 9541

• 9996

• 10027

• 10045

• 10054

• 6879, #10121

• 10219

• 10253

• 10417

• 10414

• 10441

• 10477

• 10493

• 10497

• 10498

• 10500

• 10517

• 10545 (Wontfix?)

• 10550

• 10605

• 10607

• 10647

• 10654

• 10779

• 7584 (I initially misjudged this. Interesting question)

• 10761

• 10855

• 10845 (Solvable user side already? Or only modSide)

• 7334 (Part of Multiplayerv2?)

• 10808

• 10702

• 10706

• 10931

• 10715

• 10613

• 11023

Issues that have been addressed and may need to be moved to a new issue

• 4879 (wontfix?)

• 1814

• 1925 (#663)

• 5674 (Not sure if addressed, but It probably is)

• 6636

• 7008

• 8304 (wontfix?)

• 8665

• 10432

• 10592

• 10600

• 10787 (Incomplete translation)

• 11017 (Connection issue rather than actual Unciv problem?)

[SeventhM]

Also, @SomeTroglodyte, You keep talking about redoing the CityScreen. Is that ever going to happen?

[SeventhM]

Updated OP by removing manually closed issues. I'll start marking some of them to not stall, but leave them in the op until addressed so it's easier to come back to if someone wants to address one of them

[touhidurrr]

Thanks for listing stale issues at one place so that others might take a look at them if they looking for something to contribute to.

Recently lot of my issues got marked as stale and I also ignored most of those because the sad truth is if an issue goes stale it simply means there is a lack of interest in that issue and nothing much can be done about it. Attention is a limited resource and more important issues deserves more of it.

Thus I commend your approach of listing stale issues at one place to make it more efficient to look at these issues in future and making sure that stale issues do not get lost into oblivion forever.

[touhidurrr]

Also, this issue that recently got stale caught my attention. Can you have a look at it? It feels like addressing this issue will improve lategame experience and make lategame less boring. https://github.com/yairm210/Unciv/issues/6522#issuecomment-2028436566

[SeventhM]

Also, this issue that recently got stale caught my attention. Can you have a look at it? It feels like addressing this issue will improve lategame experience and make lategame less boring. #6522 (comment)

I kinda have the same viewpoint of Yairm: Someone wants to work on it, sure. If not, I'm not sure it's particularly necessary. Pretty much the ones I saved from being stale are specifically stuff that are clear "should do later" type of stuff with little ambiguity. Here... Not so much imo.

Really, I think it's probably a fine enough thing for singleplayer, but less of a factor in multiplayer. Also, if we're asking for personal opinions, I'd say late game is boring because there's not enough stuff to do that isn't minor usually insignificant micro optimizing, not necessarily that there's too much to do, so I think would be a disagreement on how important something like unit grouping is. Granted, I'm biased as I'm pretty actively involved in another turn based as well, where specific control over every unit does matter, even if it gets boring at times