Check mod versions when online-play

[AutumnPizazz]

Before creating

• [X] This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
• [X] This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in https://github.com/yairm210/Unciv/issues/4697

Problem Description

We can add a version attribute to modOption.json, and check the version number during networking to enforce version consistency, which can avoid some errors.

Related Issue Links

No response

Desired Solution

Nothing.

Alternative Approaches

Nothing.

Additional Context

No response

[SomeTroglodyte]

Look for a closed PR - there was a version attribute, once upon a time, in some far away branch. Auto-set from release tags if the repo uses those, but free to edit otherwise... And already integrated into the when-to-update tests with fallback to timestamps if missing iirc...

[AutumnPizazz]

What's the mean of Release Tag? Unciv gets Mod in Release instead of Code Lib?

[SomeTroglodyte]

Means - look at lat-am: https://github.com/Caballero-Arepa/Latin-American_Civs/releases - we can query that stuff, and differentiate between repos that don't even have releases activated and those that use them... Then not load every last commit via the master/main/(whatever is marked as such) branch as zip, but load the release instead. Modder controls a little more directly when people update. Modder (or anyone else) can still test by feeding the branch zip URL to mod manager's explicit URL dialog.

PR was #10900 by the way

[AutumnPizazz]

That's cool, however, I would like suggest that inforce players to have the same version when online. Has this function been okay?

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 5 days with no activity.