yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.38k stars 1.56k forks source link

Feature request: Add background music or onomatopoeia #11770

Open JuanDavid45composer opened 3 months ago

JuanDavid45composer commented 3 months ago

Before creating

Problem Description

I think more music needs to be added to the game. For example, when a nation declares war on you, sound trumpets. I can support, have created several example compositions and am able to modify and compose works as needed. Declared War:

https://github.com/yairm210/Unciv/assets/172998353/355bc7df-af53-4f77-baaf-c7899c73ab94

Peace treaty:

https://github.com/yairm210/Unciv/assets/172998353/e424983d-5077-4ac9-abc1-022ee8737f84

Related Issue Links

No response

Desired Solution

More music, onomatopoeia, and sound effects should be added to the game to improve its atmosphere.

Alternative Approaches

Improving the sound section of the game would make it much better than it already is. Although it is not essential, I and other people would like it to be done.

Additional Context

No response

yairm210 commented 3 months ago

@SomeTroglodyte This looks to me like your domain :)

JuanDavid45composer commented 3 months ago

Yeah!, thank you, I'm a composer. And I am very willing to collaborate!

SomeTroglodyte commented 3 months ago

https://yairm210.github.io/Unciv/Modders/Images-and-Audio/#context-sensitive-music-overview

JuanDavid45composer commented 3 months ago

That's for mods, not the base game (like I want). Although the information you gave me was useful, thank you.

SomeTroglodyte commented 3 months ago

Was a decision back when - keep the base game light and small. Originally there was just one track, and that was not bundled either but downloaded on demand. Also, licensing for the base game must stay strictly consistent, but mods can deviate. Private music not fit for publication - Unciv plays it if placed properly. Even commercial mods aren't impossible, though harder to load (reminder to self: could we enforce a certain minimum foss spirit?).

For a rich experience, by now Unciv is meant to run with mods - even for vanilla rules. Mods are by no means required to alter any rules. There's music-only, sound effect - only, or graphic-only mods.

Mods have been left to mostly self-regulate, however. If you were to contribute, say, an incredible set of art specifically for the project, we have the option to give that preferential treatment - e.g. replacing the old "you got no music, wanna download some" button in Options where the volume sliders are. If there's enough consensus to be that unfair.

Also, if you have certain visions about how music should react to situations, that can be accommodated (in code) - that "Trigger" system and "Mood" filtering system was pretty experimental, I fully expected more updates to it in the years since than it actually got. Initially, I was just out of ideas - or it's just too "good enough" while I am playing. See - "when a nation declares war on you, sound trumpets" - I got that, with a nice fade-over from the peaceful theme it was playing before, only it's not trumpets, but that nation's "war" theme. But trumpets - easily possible. :trumpet: :musical_note: :boom:

JuanDavid45composer commented 3 months ago

I think you're right, I still hope that one day the game comes with its own music, that would be amazing. Thanks for answering!

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.