search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.09k stars 1.52k forks source link

Unable to build roads on NW #11925

Open hackedpassword opened 1 week ago

hackedpassword commented 1 week ago

Is there an existing issue for this?

Game Version

4.12.7

Describe the bug

Some time ago, I recall a change made where roads could no longer be made on Natural Wonders. Didn't want to complain and see how things evolved.

Steps to Reproduce

I've scoured release descriptions for the last year, didn't find a definitive hit. Went through code history for the below file (my good guess this is probably right) still nothing solid. https://github.com/yairm210/Unciv/commits/master/core/src/com/unciv/logic/map/tile/TileImprovementFunctions.kt

The change affected mod Z2 as roads could be built across NW bridges until this alleged modification. Questioning my recollection of the change since I can't seem to find evidence of it.

Screenshots

No response

Link to save file

No response

Operating System

Android

Additional Information

Doesn't appear to be related to terrain or improvement jsons or uniques. Map editor allows laying down roads on NW's.

Railroads are implied with roads.

Did that change actually happen? If so is this something that can be reconsidered?

yairm210 commented 1 week ago

I don't recall this ever being possible Base ruleset's natural wonders are impassible so this never cropped up

hackedpassword commented 1 week ago

Really. Yep, it was possible! :D

The last known instance via screenshots I have is Dec 1 2023. See the bridge tiles, comprised of 4 total NW's (bridge1&2 coast&ocean)

Screenshot_20231201-021609_Unciv

Somewhere in Nov-Dec, is where a really nasty crash showed itself (#10613 Nov 28) and I switched gears for a while til SeventhM solved this via #11352 Mar 21. I can't be exactly sure atm but amidst that could be why I didn't address the issue then.

hackedpassword commented 1 week ago

When I have time I'm tracing Unciv versions to isolate where a change would have happened. So far looking at about the 4.8-4.9 era.

SomeTroglodyte commented 6 hours ago

I'm pretty sure this depends only on the unbuildable property, and always has. image Modded to remove unbuildable and impassable - so the Worker can go there - from all vanilla NW, that's all.