Feature request: Change Carthage Nation Entry For Localization

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V

Mozilla Public License 2.0

8.5k stars 1.58k forks source link

Feature request: Change Carthage Nation Entry For Localization #12179

Open fantasticmrfox98 opened 2 months ago

fantasticmrfox98 commented 2 months ago

Before creating

[X] This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
[X] This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in https://github.com/yairm210/Unciv/issues/4697

Problem Description

Both Carthage (the nation) and Carthage (the city) use the same localization entry, this makes it impossible to change the name of one without changing the other, unless you replace the whole nation entry, harming compatibility with other mods.

Desired Solution

Please change the "Carthage" under cities to "Carthage City" so it can be localized separately from the nation name "Carthage."

Alternative Approaches

I do not have an alternative solution.

Additional Context

No response

yairm210 commented 2 months ago

What language is this a problem for?

fantasticmrfox98 commented 2 months ago

Well, it's not really an actual problem, per se, I made a mod that changes all the civs to use demonyms, e.g. "America" becomes "Americans," "The Netherlands" becomes "Dutch," so on and so forth. The problem comes where I can't change Carthage to Carthaginians without also changing the city to be called the same thing (unless I replace the nation entry as I said to give the city a unique entry name). This is a wish list change more than a serious issue, I understand if it's not worth the hassle.

ProgramCrafter commented 2 months ago

Incidentally, I wanted to add a civ whose capital name is "Default" by canon... I wasn't very surprised when it translated, so had to add some diacritics.

SomeTroglodyte commented 1 month ago

IF someone goes and changes the base game - suggestions:

Nation names are data "keys": Hands off - too many compatibility problems. City names are not.
A City name of "Carthage-city" with an English.properties entry Carthage-city = Carthage is possible - but could get weird if the user starts renaming the city: test that too!
Don't treat just Carthage, there's at least one other Nation with the same issue (and a few City States): Do a comprehensive list.
Incidentally, this should also "solve" the observation still some city mentions get icons (the one meant for the nation of the same name) others not - not all such places use hideIcons=true.

name is "Default" by canon

Such effects are unavoidable because the translation engine has no idea of the context - and giving it context is just not feasible (meaning some low percentage overhead cost affecting jar/apk size, memory footprint and perf BUT also more like thousands than hundreds of lines of code to change).