search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.45k stars 1.56k forks source link

Add remaining units #123

Closed yairm210 closed 5 years ago

yairm210 commented 6 years ago

A lot of this is super basic - go to Civ V wiki, see the basic unit stats, add to the json. But it's time consuming.

Filius-Patris commented 6 years ago

Is UnCiv/android/assets/jsons/Units.json the only Json, which needs to be edited, or is there some other Json (eg. in the ios directory) which needs to be edited?

yairm210 commented 6 years ago

That's the only one, but A. There are some techs that currently don't exist in the tech tree (steel, gunpowder) for advanced units B. Each unit needs an icon in Assets/UnitIcons

Filius-Patris commented 6 years ago

Should the contents be based on Civ V (original), Gods & Kings or Brave New World?

Also, should the tech "Agriculture" be added?

yairm210 commented 6 years ago

So far I've gone with the information in civilization. Wikia.com, it seems to be the most thorough

As for the techs, they're based on the original Civ V tech tree (update .332 to be exact)

Am-per-Sand commented 6 years ago

I developed the file https://github.com/yairm210/UnCiv/blob/master/android/assets/jsons/Units.json

Paste-ready, but please verify: uniques uniqueTo civ names

yairm210 commented 6 years ago

Thanks for this! There are a couple of pain points for units: One is finding a good image =\ (I usually use https://thenounproject.com) Another is implementing the unique abilities in the code A third is that (currently) not all of the technologies actually exist 0_0 (I started making this game without units and so removed all "extra" technologies that dealt solely with combat) So it's not quite as simple as copy-paste Also, expanding the units is pretty far down the todo list as of now =\

Am-per-Sand commented 6 years ago

Therefore I don't expect to see these new units in games only after you paste them into your file. But hope to see them some day when the code and images are ready for them.

Anyway, please derive from https://github.com/Am-per-Sand/unciv/blob/master/units.json, I'll try to enhance it in the following days.

yairm210 commented 6 years ago

Range for ranged units defaults to 2, so you don't need to specify it

From: Am-per-Sand notifications@github.com Sent: Monday, June 25, 2018 8:58 PM To: yairm210/UnCiv Cc: yairm210; Author Subject: Re: [yairm210/UnCiv] Add remaining units (#123)

Therefore I don't expect to see these new units in games only after you paste them into your file. But hope to see them some day when the code and images are ready for them.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yairm210/UnCiv/issues/123#issuecomment-400040773, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH-ogEnq5WAY0nCOj9ifLPGeZwTRECcpks5uASTEgaJpZM4T7Z3u.

Am-per-Sand commented 6 years ago

include available promotions in uniques?

PS. Found it: they're included in a separate file https://github.com/yairm210/UnCiv/blob/master/android/assets/jsons/UnitPromotions.json

Update: All internation land & air units have their properties in json and added some unit icons

yairm210 commented 6 years ago

In the original game, even if a unit can upgrade out doesn't mean you can't train the previous For instance horseman upgrades to Knight But since it has a higher movement than Knight, It only becomes obsolete after lancer, which has the same movement as it, exists Also, warrior upgrades to swordsman, but if you don't have iron then you can't train it, so it doesn't get obsoleted until you can train spearman I think?

Tuesday, 10 July 2018, 10:42p.m. +03:00 from Am-per-Sand notifications@github.commailto:notifications@github.com:

include available promotions in uniques?

PS. Found it: they're included in a separate file https://github.com/yairm210/UnCiv/blob/master/android/assets/jsons/UnitPromotions.json

Is obsoleteTech optimal choice? How about the code checking for value of the upgradesTo property and then checking if such a unit (exists and) has requiredTech property and such a technology is currently available? If it is then the unit is obsolete? Or may be it is better to have a redundant property?

Update: All internation land & air units have their properties in json and added some unit icons

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yairm210/UnCiv/issues/123#issuecomment-403942767, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH-ogDYcWAcrMROryhQJeYc7mM5oaC1Tks5uFQO2gaJpZM4T7Z3u.

Am-per-Sand commented 6 years ago

I used this to fill obsoleteTech property: https://forums.civfanatics.com/threads/units-and-techs-at-which-they-become-obsolete.455025/

I also made icons for the 4 units that I think are ready to introduce to the current code: Hoplite, Composite Bowman, Musketeer, War Chariot. You may find them in my repository and add to yours. I would also add Romans to Civilizations.json, if I knew their RGB color, for Ballista and Legion are ready as above. Like other units, that may be introduced, but I think will need further code development, ex. for "Can attack twice", "Bomb" etc. Could you please direct my further work so as it matches code versions to appear in the nearest future? Would naval units properties be more helpful? Or rather modern land units icons?

Am-per-Sand commented 6 years ago

I notice you added the Ballista for Romans. Are you going to add Legion? Do you still need any help in adding unit properties and icons?

yairm210 commented 6 years ago

Eventually, I hope to add all the units. But that's pretty for away right now. So as of now, preparing metadata won't be very helpful But thanks for offering!

yairm210 commented 5 years ago

566 is a subgroup of this, since this issue was not well defined (no clear DoD)