Feature request: Unit Type Icons as missing Unit Icons.

prod0ad commented 1 month ago

Before creating

[X] This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
[X] This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in https://github.com/yairm210/Unciv/issues/4697

Problem Description

I noticed we can have UnitTypeIcons and thought those could be used as missing specific unit icons of that type. As a placeholder, a design choice, or to save icon space.

Examples: A mod that uses Icons for Classes/types, not specific units. A mod where some units, say heroes, could share the same Icon.

Desired Solution

The game reads files as described.

Alternative Approaches

While we're at this, is there a way to hide unused domain categories from civilopedia?

Additional Context

No response

yairm210 commented 1 month ago

Interesting! Good idea!

prod0ad commented 1 month ago

Nice:) Maybe this could be extended to other things too?

Like default icons for resource, tech, policy (maybe the main branch could be a fallback for sub-policies), unit-type sprite icons etc. Especially the later I see as most useful.

prod0ad commented 1 month ago

Btw just tested, doesn't seem to work.

New units ignore the unit-type icon, the rest fallback to base game ones. Or to other active perm audiovisual mod they share unit names with, is that intended?

yairm210 commented 1 month ago

Welp, I done goofed, my bad

prod0ad commented 1 month ago

It works now on the map. But not in city construction queue, civilopedia and combat screen. Not sure if I've missed any.

Btw I noticed Unciv ram use increase with time (reached up to almost 9 GB and major computer lag). Is this normal, or, since I've never noticed that before even in longer sessions, some new memory leak or something?

yairm210 commented 1 month ago

That's definitely a problem, but whether it's new or not isn't something I can know 🤔

yairm210 / Unciv