search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.45k stars 1.56k forks source link

Templated replacements for TileSetConfig #3801

Closed GGGuenni closed 3 years ago

GGGuenni commented 3 years ago

Sorry for the late reply. I'm currently a bit busy working on my bachelor thesis. I created this issue because I didn't want to answer on a closed PR.

Maybe we can add templated replacements, like "Hill+(resource)+(improvement): [ "Grassland", "Hill", "(resource)", "(improvement)" ] That will both make sure we don't miss things and accommodate mods.

I thought about that and I really liked the idea. I discarded it because I thought it would make everything pretty complicated. I currently have no clue where to start with templated replacements, to be honest, but I mean I can try.

yairm210 commented 3 years ago

It's just an idea, there's plenty of other stuff to do, and none of this is time critical Good luck on your thesis! :D

yairm210 commented 3 years ago

I no longer think this is necessary, the current configuration handles the issues well