lishaoxia1985
commented
3 years ago At first, the mod should contain md5 check information, it can be used to check whether the mod downloaded is the whole one and needs to update.
Closed SomeTroglodyte closed 3 years ago
lishaoxia1985
commented
3 years ago At first, the mod should contain md5 check information, it can be used to check whether the mod downloaded is the whole one and needs to update.
SomeTroglodyte
commented
3 years ago Not a bad idea per se, but ... how to get from github without too much overhead?
As you can see, tons of redundant info but no checksum-type data. id and node_id will not change on update. The /repos API also does not have more info.
And I wouldn't download each and every zip in its entirety to hash it...
Update:
You do get sha hashes - for commits and files through the branches api. Not for the entire repo, so we wouldn't be checking local integrity...
No, updated_at is the best change detector whe have. (?)
ajustsomebody
commented
3 years ago i havent tested the mod but those images over mod size should really be scaled up/down to one size, it is really unpleasant to have those in different dimensions
SomeTroglodyte
commented
3 years ago They are. I chose user avatars to be smaller than splash screens, though.
I got side-tracked and improved the mod manager screen. Too big for a single PR - and before splitting it into digestible chunks I'd like to sound the waters - likes, dislikes, bug reports, facepalms.
If you have Android Studio set up and would like to help, please take a moment to pull the branch and playtest it.
jarplayers - sorry I forgot how to build one.Instructions - you have cloned a fork and set up everything according to this - this should work:
SomeTroglodyte/ModManager-tweaksbranch - it should be visible unless you used show favourites only, forgot the fetch, or are too fast for that fetchShift-F9and open Mods right awayOtherwise - Android Studio but no Unciv as ready project - you should be able to just
Get from Version Controland use my git URL above, no credentials necessary as all Unciv forks are public, and follow the wiki to get a 'desktop' run configuration (and maybe refer to my notes for some details like having to wait for the gradle indexer before the 'classpath' dropdown knows enough about the project.... Then switch branch as above and go?Screenshots:
The little eye icon is old, the little arrow I borrowed from the 'Resume' main menu button indicates mods used in any current savegame including autosaves (helps not deleting them - but does not lock the delete button - yet?), and there's an indicator for outdated mods needing an update too (mirrors the " - Updated" added to mods in the middle column, and is cleared - along with the button addition - when you update it.
As for the colourful decoration in the right-hand column - take a guess. I'll have to take down my splashscreen.jpg and replace it, as I forgot to update credits.md for it and lost the attribution. There's an improvement for that not yet coded, will just feel faster with a little better queue prioritization.
Other ideas on the todo list: Column sorting, syncing an installed mod to scroll its online button into view, deleting a ImagesToNotAddToGame if it exists, and fixing a tiny problem 5Hex may soon show: Updating an already installed mod which has removed files will not clear them locally, so your downloaded mod may in time behave differently than what the author intended.
Another request for comments: No existing mod but mine uses the existing feature that contained zips are unpacked recursively. Current master will unzip these into the mod root no matter in which subfolder they were found, and then leave them. My branch here will unzip relative to the sub-zip's container folder, and I have on my list to delete them afterwards. Which do you think is the best approach? As far as I can see, this is not documented yet.
Lastly, the Mods wiki entry would need updating - for mod splash screens if we merge this, for sub-zips, and possibly for the atlas issue (I'm 95% positive a mod must include and maintain its atlas + corresponding png on its repo, as these are used by mobile devices, not the Images folder, right? One could even drop the Images and the mod would work if I'm not mistaken. I think the wiki could be a little clearer on that).