search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.49k stars 1.57k forks source link

Farms pixel improvement not visible for specific Android user #4266

Closed ajustsomebody closed 3 years ago

ajustsomebody commented 3 years ago

Screenshot_20210625-183742_UnCiv.jpg

3.15.4 dont think i need to provide a save file

yairm210 commented 3 years ago

Working for me, this looks like a you problem. By which I mean, you probably have a visual mod or something.

ajustsomebody commented 3 years ago

Working for me, this looks like a you problem. By which I mean, you probably have a visual mod or something.

Screenshot_20210627-092324_UnCiv.jpg

Screenshot_20210627-092351_UnCiv.jpg

Screenshot_20210627-092337_UnCiv.jpg

Nope, something is definitely wrong

AdityaMH commented 3 years ago

Ever trying 5hex? and what mod you using?

ajustsomebody commented 3 years ago

Ever trying 5hex? and what mod you using?

i am not using any mods, and it might or not work in 5hex, the problem here is that farms dont work in inbuilt tilesets

jahodovykolac commented 3 years ago

My ~useless~ tips

ajustsomebody commented 3 years ago

My ~useless~ tips

  • Try turning off and on pixel improvements
  • Check for any enabled permanent visual mods (they don't need to be used in the game)
  • Try 5Hex

everything is on all normal settings and i dont like using 5hex

jahodovykolac commented 3 years ago

everything is on all normal settings and i dont like using 5hex

I didn't mean normally using it, just for testing. Otherwise, working fine for me...

ajustsomebody commented 3 years ago

so... anyone has any idea why this might be happening?

jahodovykolac commented 3 years ago

Can you try if it's only for farms? Also, are you on mobile or PC?

ajustsomebody commented 3 years ago

Can you try if it's only for farms? Also, are you on mobile or PC?

mobile, only for farms

jahodovykolac commented 3 years ago

Looks like the file for farm image got corrupted or something. Because I don't know any way of accessing game files on mobile, I would suggest making a backup of your saves (copying the files, they're accessible: mobile storage/android/data/com.unciv.app/files/SaveFiles) and reinstalling. I hope making a backup can work like this

ajustsomebody commented 3 years ago

@yairm210 just redownloaded the game, updated it to 3.15.6 from 3.15.5-1 and the problem still persists

Screenshot_20210702-113853_UnCiv.jpg

yairm210 commented 3 years ago

That's because it's not a version problem, it's a you problem... this isn't happening to anyone else as far as I can tell.

ajustsomebody commented 3 years ago

That's because it's not a version problem, it's a you problem... this isn't happening to anyone else as far as I can tell.

i've definitely seen that happen to someone else as well, its just that i cant point out who, you should make a poll on discord if people are also experiencing this problem as well

AdityaMH commented 3 years ago

Screenshot_2021-07-02-17-55-01-031_com unciv app What android version you used?

SomeTroglodyte commented 3 years ago

I'm pretty sure I've seen it as well, though I do not know how to reproduce. A minimal save - start as small as possible, provide here as soon as issue visible - might help. Or a copy of the actual game.atlas used at the moment of seeing the issue. Which you can't access on mobile. I could - knowing precisely which apk is running with 100% certainty that I have the same one would do it.

Looks like the file for farm image got corrupted or something

FYI: Mobile does not use the contents of the Images folders here, only the atlas and the corresponding packed png. There is no single Farm image at all, and as far as I can see that's intentional which leads to:

I can repro a similar issue, Base+Farm+Resource will not work in (some? most? all?) cases because there is no single "Farm.png", no all-together-png or ruleVariants entry (checked from debugger, not cross-checked with the json). Only existing mods in test rig are unrelated - sounds and leader portraits. E.g. Plains+Farm+Incense or Desert+Farm+Silver will show the issue. ruleVariants for these mapping e.g. Desert+Farm+Silver to ["Desert+Farm", "Silver"] would certainly solve this... But I'd like to understand this case (no resource, so the Base+Farm png should be picked without a ruleVariants automatically) and #4362 before I do something about it.

P.S.: OK, Internally it's not Desert+Farm+Silver but Desert+Silver+Farm but that doesn't change the validity of the argument.

P.P.S.: Without a plain Farm.png (which would need a lot of transparency), this would get a sisyphus task. No Desert+Hill+Farm.png, no Plains+Hill+Farm.png, need to consider resources that can remain on a tile after chopping down a forest or jungle and consider farms allowed on fresh water too - and the number of required ruleVariants gets staggering.

DonColasanti commented 3 years ago

I experienced the problem too. I am running on a motoZ4. Most current f-droid version.

ajustsomebody commented 3 years ago

I experienced the problem too. I am running on a motoZ4. Most current f-droid version.

@yairm210 i dont think if it this way for only a specific user (me)

ajustsomebody commented 3 years ago

@yairm210 it got fixed by itself for some reason on 3.15.11 for me

modded and vanilla screenshots

Screenshot_20210715-083237_UnCiv.jpg

Screenshot_20210715-083126_UnCiv.jpg

it might be fixed in mine but did it on other people's games too?

AdityaMH commented 3 years ago

If my folder mod "include" fantasyhex. That all farm become hidden. Weird thing.

SomeTroglodyte commented 3 years ago

Hey, that could well be the answer

ajustsomebody commented 3 years ago

@yairm210 its broken again lmao

Screenshot_20210716-125625_UnCiv.jpg

3.15.11

xlenstra commented 3 years ago

Try uninstalling any mods that provide their own fantasy hex tileset and restarting your game.

ajustsomebody commented 3 years ago

Try uninstalling any mods that provide their own fantasy hex tileset and restarting your game.

i dont think if it is sustainable as any mod that provides a texture file wouldn't be able to be used if you want to keep farm textures

AdityaMH commented 3 years ago

Try uninstalling any mods that provide their own fantasy hex tileset and restarting your game.

This fix "farm phantom" bug. But why?

ajustsomebody commented 3 years ago

Try uninstalling any mods that provide their own fantasy hex tileset and restarting your game.

yep, it works that way however this isnt sustainable

SomeTroglodyte commented 3 years ago

Why? Probably because the layering algorithm needs all components in the same place. Good hint, someone will investigate when they're otherwise bored :laughing:

SomeTroglodyte commented 3 years ago

If my folder mod "include" fantasyhex. That all farm become hidden. Weird thing.

Thanks for the trigger!

AdityaMH commented 3 years ago

Yesterday farm phantom, now lumber mill phanthom. IMG_20210726_033446

SomeTroglodyte commented 3 years ago

Now this is a separate issue. Seems to happen for Plains+Hill+Forest+Lumber mill and Tundra+Hill+Forest+Lumber mill because those have neither a ruleVariant nor an allTogether image nor does a 'Lumber mill.png' exist by itself. There's a 'HillForest+Lumber mill' png that looks completely unused that maybe would serve for a ruleVariant...

Well, 

        "Plains+Hill+Forest+Lumber mill": ["Plains","HillForest+Lumber mill"],
        "Tundra+Hill+Forest+Lumber mill": ["Tundra","HillForest+Lumber mill"],

work well enough but that's not the whole ticket. Not my expertise really.

ajustsomebody commented 3 years ago

this farm one is fixed btw, but you might want to still keep it up due to @SomeTroglodyte's comment above, and the problem adityamh has experienced from what i understand they are basically the same problem

SomeTroglodyte commented 3 years ago

Nope, the fix 4553 prevents inappropriate tileset json from being active - e.g. DeCiv's json interfering when you aren't playing DeCiv. The lumbermills look more like incomplete FantasyHex itself. Farms on desert hills likewise.