search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.49k stars 1.57k forks source link

Show starting speech only when it exists #4438

Closed jahodovykolac closed 3 years ago

jahodovykolac commented 3 years ago

Is your feature request related to a problem? Please describe. When playing a modded civilization older than starting speech, it shows only TBD TBD

Describe the solution you'd like The speech window would not show up if mod doesn't contain the speech text.

SomeTroglodyte commented 3 years ago

What's a speech window? As far as I know Unciv has no speech recognition or -output.

xlenstra commented 3 years ago

I believe he means the large wall of flavor text that appears when starting a new game, describing the civ: "Oh, Julius Caesar, emperor of Rome blah blah blah will you create an empire that will stand the test of time?" etc.

jahodovykolac commented 3 years ago

Yes, I mean this thing, I don't know how is it called.

yairm210 commented 3 years ago

This is already the case in code - this seems to be a mod issue. I see for example that Medieval Civilizations and Ancient Civilizations mods have this, please contact the author of the mod you're using

SomeTroglodyte commented 3 years ago

Well, it is filtered on it.nation.startIntroPart1.isNotEmpty(), so I wonder how it could ever pop up a non-existing Start Intro... GameStarter.kt Line 80

jahodovykolac commented 3 years ago

This is how it can pop up.

Screenshot_20210713-115018_UnCiv

~Also, I don't understand how these things work, but just a thought, couldn't it be caused by "part 1" being specified there?~ nope a stupid idea

SomeTroglodyte commented 3 years ago

Ah, literal "TBD" -> definitely a mod error. The mod does contain "speech text", and it is "TBD", twice - so you see how your original "Describe the solution you'd like" doesn't really apply. Unless we special case the "TBD" string and then - where do we stop? "WIP"? "Not yet ready"? Analogous strings in the modder's native tongue? No thanks.

jahodovykolac commented 3 years ago

Ok, thanks for explaining :)