search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.32k stars 1.56k forks source link

Changes to local mod files should be updated without a game restart requirement #4725

Closed ajustsomebody closed 3 years ago

ajustsomebody commented 3 years ago

i think there should be an option for local mods where they are updated in-game when any of the files change in the mod files, this is especially useful as you need to actively work on jsons and have to restart unciv every time you do it.

Caballero-Arepa commented 3 years ago

Yeah, it is annoying to have to reopen unciv to update a mod. But I don't know if its possible to add.

xlenstra commented 3 years ago

While this is not impossible, I feel like the time it will cost to implement this will be longer than the total amount of time it saves modders

ajustsomebody commented 3 years ago

While this is not impossible, I feel like the time it will cost to implement this will be longer than the total amount of time it saves modders

the maybe the game should restart when any of the files change if the player isn't currently in a game, enabled with an option of vourse. this isnt a great way but most certainly better than nothing, however i think it would be horrible for this to be in the game forever

yairm210 commented 3 years ago

This is not cost effective at all. Denied.

ajustsomebody commented 3 years ago

This is not cost effective at all. Denied.

outside of accepting this or not, do you think that it would be too hard to implement? wouldnt there be a half working quick fix like uninstalling and installing the mod through the code when any of the files are changed?