search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.26k stars 1.55k forks source link

[Translation issues] Lines not translatable or broken entries #6131

Open Ouaz opened 2 years ago

Ouaz commented 2 years ago

Here's a list of entries which still appear in english when the game is set to another language, either because entries are missing in template.properties (easy to fix) or the game code doesn't allow entries to be translated (harder to fix). There is a screenshot (in french) for each entries under the spoiler tag. Maintainers can edit the message to tick checkboxes when fixed (I think)

- Fixed -

Reported by @saud2410

- Fixed - Finally, all Policy name (Honor, Liberty, Piety, etc.) translations have been removed in 3.19.2. I think it is intended, and the translation entries will come back in a future release, according the guidelines. EDIT: Strings are back in 4.0.1.

The list is complete, I hope it won't be too boring to fix. :p

saud2410 commented 2 years ago

All "See also" entries in tech screen (There's no problem in civilopedia)

Screenshot_20220210-194151_UnCiv

Screenshot_20220210-194236_UnCiv 20220210_195047

Screenshot_20220210-194126_UnCiv

Screenshot_20220210-194118_UnCiv

Screenshot_20220210-194109_UnCiv

Screenshot_20220210-194059_UnCiv

Screenshot_20220210-193612_UnCiv

yairm210 commented 2 years ago

I think the 'see also' should be removed entirely since it says what effect it has

saud2410 commented 2 years ago

Type

Details 3.19.6 on Android 11, apk In civilopedia, Type: is not translated. ![Screenshot_20220212-011954_UnCiv](https://user-images.githubusercontent.com/64586749/153628951-11102c37-5871-4b6f-bc12-f572144008ac.jpg) It's translated in diplomatic screen. ![Screenshot_20220212-011906_UnCiv](https://user-images.githubusercontent.com/64586749/153628942-81fd7475-b271-48a4-b698-3d43b8bf0200.jpg)
saud2410 commented 2 years ago
Details It can be found in civilopedia and new game screen. (3.19.8, apk on Android 11) ![Screenshot_20220214-022521_UnCiv](https://user-images.githubusercontent.com/64586749/153767138-9838ba8b-126f-4613-b869-f3fa21325567.jpg)
yairm210 commented 2 years ago
  • [ ] Great Person

Details It can be found in civilopedia and new game screen. (3.19.8, apk on Android 11) Screenshot_20220214-022521_UnCiv

That was already in the original post

saud2410 commented 2 years ago

Sorry i remember that i checked but i didn't delete it from my list

saud2410 commented 2 years ago

Archery (please read details)

Details 3.19.8, apk on Android 11 ![Screenshot_20220214-023044_UnCiv](https://user-images.githubusercontent.com/64586749/153768009-fb6d9b3c-4000-435e-bfce-ff70d06b10d3.jpg) Bottom line is translation of "Archery", 궁술. Yes, we have Archery translation cuz it's ancient tech. And here "Archery" as an unit type seems to refer "ranged cold weapon". However, 궁술 means only "Skills of archery" in Korean. 궁술 doesn't indicate any weaponry or soldiers. Please consider making new name of ranged-cold weapon unit type. I've considered am i okay to ask something related only in my language in here. But i can't get answer for myself so i just comment this.
yairm210 commented 2 years ago

Then just use what you would use for "archery units" as the tech name

Ouaz commented 2 years ago

@saud2410

Yes, there's several english entries that are used in a different context (in your example, a tech name used as a unit type for promotion), which makes sense in english, but not so much in other languages. We have to be inventive to keep the "same" meaning everywhere in our native language. :sweat_smile:

For example, in french, "gunpowder" (tech) is translated "poudre à canon" (literally "cannonpowder") as we don't have another word for it. So, it looks a bit weird as a unit type in promotion, and I can't change it, because it is the tech name.

So, I did a little trick by translating "Ranged Gunpowder" (untranslatable in french anyway, because we only have "poudre à canon") by "poudre d'artillerie" (literally "artillery powder"), so player should understand that one means "gunpowder melee combat" and the other "gunpowder ranged combat".

It's not perfect (french people don't really say "poudre d'artillerie"), but I think it's the most acceptable workaround.

@yairm210

Thanks for the already done fixes!

saud2410 commented 2 years ago

@yairm210 I've never expected "willing yes" or smth, but what you say isn't gonna work. It's already Civ5 official translation, and player sees tech more than unit type. Tho i don't know how-to, I'll understand it as "if you want, do it yourself".

But let me ask you something. Does "ranged cold weapon" type exists in Civ5? How does it used?

@Ouaz Thanks for your words, but you never know how much i'm already trying to be "imaginative". Expression always matters. Maybe more than expression. But Koreans have additional characteristics like postpositions. I can't explain how does it feels to other language spreakers, but if you look Korean.properties there's so many ( ) things, and most of them are unnecessary. I always do try to keep in mind "It's already lucky that i can translate it". But if the system seems different from Civ5, imao i have to say "could you-".

Ouaz commented 2 years ago

but if you look Korean.properties there's so many ( ) things

Haha, me too! For example, english doesn't have gender for words, but french does. So An enemy [unit] must be translated Un(e) [unit] ennemi(e), because in french, [unit] name can be a masculine or feminine word, so the determiner and adjective have to be adapted accordingly.

What I want to say by "imaginative" is that sometimes we are stuck with translation, because english language has a different (and a lot easier imo) grammar and lexical field, that makes things not convenient to translate (especially in videogames, moreover in 4X games).

We have to deal with it, and find the most acceptable way to translate some parts of the game, even if it gives sometimes a not-so-good result in our native language, but making it still easily understable by the player.

And I think what Yairm said was truly a suggestion, not something to be understood as "if you want it, do it yourself". :smile:

Ouaz commented 2 years ago

3.19.9

- FIXED - type and "when friends", "when allies" (in civilopedia nation articles) - FIXED - units (in Free Speech policy) (my bad!) - FIXED - for (in civilopedia improvements article) - FIXED - Not related to translation, but ressources icons in civilopedia improvement articles are now missing:

details
Ouaz commented 2 years ago

3 new strings not translated added. For screenshots, see the top of the list in the opening post:

yairm210 commented 2 years ago

Can you add a screenshot for the "null in plantation"?

yairm210 commented 2 years ago

Sorry, now saw your earlier post :)

Ouaz commented 2 years ago

Following b8d8e11 that fixed "null" in Plantation, it seems it causes another translation problem in the same string :sweat_smile: :

- FIXED - in [Bananas] tiles

Details - When choosing a Plantation as tile improvement, description has some part untranslated and unformatted. Follows the fix for "null" in Plantation (b8d8e11) . Note: this line is displayed correctly in Plantation civilopedia article.

(added to opening post)

Note: the line for Plantation bonus: +1 Gold for Cotton, Dyes, Incense, Silk, Spices, Wine, Sugar, Citrus has disappeared both in Civilopedia and improvement tile building screen, but I think this is intended.

yairm210 commented 2 years ago

'units cost no maintenance' looks like a you problem:

[amount] units cost no maintenance = [amount] units ne coûtent aucune maintenance

Ouaz commented 2 years ago

'units cost no maintenance' looks like a you problem

Oh my god, how could have I miss that. I'm so sorry! Shame on me. :sweat:

Ouaz commented 2 years ago

3.19.10 New batch:

- FIXED - Hurry Construction (+[productionAmount])

Details - When a Great Engineer is inside a city and can hurry the current construction, the button is not translated. The line is yet in the translation file. (outside the city -so unavailable button-, the button is translated)
Inside the city - not translated

Outside the city - translated

- FIXED - National ability

Details - National ability combat bonus in battle table. This line exits in the translation file though.

- FIXED - Unit ability

Details - Unit ability combat bonus in battle table. Like "National ability", this line exists in the translation file.

- FIXED - Never appears as a Barbarian unit (the return)

Details - Follows 7887e7a . "Never appears as a Barbarian unit" has been removed from tech descriptions, but still appears when selecting a unit to build (like the Knight) in the city construction screen
Ouaz commented 2 years ago

3.19.12

- FIXED - Protected by: [Civ name]

Details - In city-state diplomacy screen, names of the civs protecting a city-state are not translated. In this example, The Huns and Ethiopia.

- FIXED - You have won a [type] victory!

Details - When winning a game, in Global status screen, the line saying which type of victory has been achieved, is not translated (only the type actually, not the full sentence). There's some corresponding lines in the translation file, but without the [type] key.
Ouaz commented 2 years ago

3.19.17

The newly introduced strings in construction queue, are not translatable.

- FIXED - Requires a specific building in all cities!

Details - In construction queue

- FIXED - Consumes resources which you are lacking

Details - In construction queue

- FIXED - Requires a specific building in this city!

Details - In construction queue

- FIXED - Requires more population (broken again, was fixed a few releases ago)

Details - In construction list, in city screen
Ouaz commented 2 years ago

4.0.0

-FIXED- Upgrade (old one apparently, that I didn't notice yet)

Details - Column title not translatable in Overview - Units screen

-FIXED- Followers of this Religion

Details - In some belief descriptions (Asceticism, Choral Music, Liturgical Drama, Religious Center) using the new string (in cities with at least [amount] [populationFilter])
SomeTroglodyte commented 2 years ago

Finally, all Policy name (Honor, Liberty, Piety, etc.) translations have been removed

I can clarify: The TranslationFileWriter has the ability to look up one level in the Class hierarchy, and we introduced another level with RulesetObject. This is why neither name nor uniques from PolicyBranches are scanned... Fix in testing.

SomeTroglodyte commented 2 years ago

I'm ticking off directly in the first post stuff I've got fixed - in #6421, #6433 or in the branch I'm working on.

SomeTroglodyte commented 2 years ago

@yairm210 "Remove Foreign religions from your own cities" - case is inconsistent IMHO. Change to "Remove foreign religions from your own cities" or "Remove foreign Religions from your own cities" as soon as possible??? Only in the Unique, not the const val removeHeresyAbilityCount because changing the latter would give a few gamers free uses in existing saves?

Ouaz commented 2 years ago

4.03

This one was translated before... I can't say when it has been broken.

-FIXED- Revoke protection for

Details - In city-state diplomacy screen, when clicking "Revoke protection" button (which is translated), the popup is not translated
Button correctly translated :

Popup not translated :
SomeTroglodyte commented 2 years ago

Revoke protection for

True, that needs a Revoke protection for [cityStateName]? = in template.properties. Go ahead.

yairm210 commented 2 years ago

So we finally finished this. Great work everyone :)

Ouaz commented 2 years ago

@yairm210 (sorry, I ping you because I don't know if you will receive a notification, as the issue is now closed)

So we finally finished this. Great work everyone :)

"You spoke too fast, young man". :D

4.0.7

The new "Go To on Map" button in the city-state diplomacy screen, is not translatable:

- FIXED - Go To on Map

Details - New button in the city-state diplomacy screen
Ouaz commented 2 years ago

4.09

Hello, unfortunately, some fixes didn't work and there's a new one too:

- FIXED - Go to on map (despite 42865bd)

Details - New button in the city-state diplomacy screen still not translated

- FIXED - Add all [param] in the capital ([param] = spaceship parts)

Details - In victory conditions screen, "spaceship parts" is not translated
Ouaz commented 2 years ago

Hello!

4.11

- FIXED - Followers of this religion (tied to 7af2748)

Details - In Religion screen, the new line that counts the total number of followers for a religion, is not translated. "Followers of this Religion" exists in the stringtables, but "religion" is not capitalized in the new string code.
Ouaz commented 2 years ago

4.12

- FIXED - Consumes 1 [resource]

Details - In the City screen, when choosing an unit to build, in the lower-right info panel. The string already exists in the translation file, and there was no problem in previous versions.

- FIXED - Max zoom out

Details - In the advanced options menu
SomeTroglodyte commented 2 years ago

Consumes 1 [resource]

Ouch - I'll fix

SomeTroglodyte commented 2 years ago

Followers of this religion

Double ouch: "Followers of this Religion" (Unique parameter), "Cities following this religion:" (just the one), "in cities following this religion" (Unique parameter), "Click an icon to see the stats of this religion", "when killed within 4 tiles of a city following this religion", "for each global city following this religion", "Followers of the Majority Religion", etc...

Clearing that will be a SEP, but it confused me to the point I added a template with lower case and colon then added the braces to use the existing translation instead - not seeing the U/l-case difference. I'll leave the template as is and just use it.

Add all [param] in the capital ([param] = spaceship parts)

Will need TranslationFileWriter debugging

togo on map

Trivial to fix

SomeTroglodyte commented 2 years ago

Add all [param] in the capital ([param] = spaceship parts)

@ All Coders: For a Unique-like pattern, a parameter is itself not passed to the translatables result by TranslationFileWriter, and most UniqueParameterTypes will be OK as the string will be provided elsewhere. One exception would be untyped "Triggers the following global alert: []" - its only param has been manually added to templates.properties. That could be done with "spaceship parts" as well, close the lid and move on. But IMHO that is not as mod-friendly as could be. I'd actually add the param to the output if the parameter type guessing defaulted to Unkown (and remove the template for the Patronage Complete alert as it will reappear immediately from that code change)... So a modder using TranslationFileWriter could rejoice that he's asked to translate his "Terraforming module", whatever, automatically. Opinions? Simple or...?

Ouaz commented 2 years ago

Oye oye,

4.0.13

Sorry to post translation bugs one by one, but... I noticed them one by one.^^ And if I knew how to fix them, I would do it. Big thanks to coders here who take time to fix all of this.

Ouaz commented 2 years ago

:(

The issue has been closed... but in 4.15, "May buy [baseUnitFilter] units with [stat] for [amount] times their normal Production cost" not translated in Holy Warriors belief article has not been fixed.

See above for screenshot https://github.com/yairm210/Unciv/issues/6131#issuecomment-1120104423

Yeah, I'm annoying! :D

SomeTroglodyte commented 2 years ago

annoying

Pas du tout. You're our official detector. If you look at the timeline, I coded a PR before you added the holy warriors one, and by using the magic words "Fixes # 6131 again" that PR closed this issue automatically when merged. That's just how this ecosystem ticks. Either one of us remembers to double-check... or not.

Ouaz commented 2 years ago

Hallo!

4.1.3

- FIXED - Wait

Details - The new "Wait" command in unit action list, is not translatable.
SomeTroglodyte commented 2 years ago

Wait

:facepalm: Of course, we discussed clones not words...

Ouaz commented 2 years ago

Buongiorno a tutti,

4.16

Not a big deal, as these new untranslated strings are outside the "main" game, but in Unciv launch menu.

- FIXED - Friends list

Details - In "Multiplayer" game menu, the new "Friends list" button is not translated. It is in the stringtables though.

- FIXED - [saveFileName] deleted successfully.

Details - In "Load" game menu, when deleting a save, the "success" line is not translated. It is in the stringtables though.

- FIXED - Please input player ID

Details - In "New Game" menu, when creating a new multiplayer game. I noticed it a long time ago, but never reported it, as it was very minor. The string is not in the translation file.

That's all! Thank you.

SomeTroglodyte commented 2 years ago

The current templates have the help entry as follows:

To add a friend, ask him to send you his player ID.\nClick the 'Add friend' button.\nInsert his player ID and a name for him.\nThen click the 'Add friend' button again.\n\nAfter that you will see him in your friends list.\n\nA new button will appear when creating a new\nmultiplayer game, which allows you to select your friend. =

.. and it works.

Friends list

A matter of case again.

deleted successfully

My bad.

Please input player ID

simply missing template

May buy [baseUnitFilter] units with [stat] for [amount] times their normal Production cost

Now this is tricky - tr still gives {} precedence over [] bypassing all of the normal unique tr stuff...

Ouaz commented 2 years ago

The current templates have the help entry as follows: "Too add a friend, [...]" .. and it works.

Holy... How could have I miss it? I checked 2 times the translation files and yet I missed it 2 times. If I don't translate it, sure it won't work... ^_^' My apologies for the extra work/check!

heipizhu4 commented 2 years ago

I found this untranslatble 3a8dc9917e640e86b8cfbf8bdda358cf80c5d23b I wonder if we can get this thread pinned, for it has been updating all the time.

Ouaz commented 2 years ago

4.1.10

I confirm, thanks to heipizhu4. (Edit: also reported in #7246)

"Consumes n [resource] (n available)" is back. Yet it has been fixed a first time (for "Consumes n [resource]") here : https://github.com/yairm210/Unciv/pull/6705/files#diff-15255a0e8377066182f36febfe1e5e9d14cc3efcfcfaaf04a29ddd1ac132e620

I updated the opening post (+ a bonus one):

- FIXED - Consumes n [resource] (n available) (back from the dead! Fixed a first time in #6705 )

Details - In the City screen, when choosing an unit to build, in the lower-right info panel. The string already exists in the translation file.

- FIXED - Enter search text

Details - In the Mods menu, in Sort and Filter text area, the hint text is not translatable.
Ouaz commented 2 years ago

4.1.11

Aloha,

I don't know what happened, but a lot of strings are broken (again), or there was no problem with them before. Let's go.

- FIXED - Add all [param] in capital

Details - In "Our status" screen. This has been already fixed in the past. Broken again. :D

- FIXED - Complete [amount] Policy branches

Details - Still in "Our status" screen.

- FIXED - Remove [feature] first - FIXED - Research [tech] first - FIXED - Have this tile inside your empire

Details - When picking an improvement to build with a worker. I think all the requirement infos are not translated anymore (they were before). Below a screenshot with some of them:

That's all... for now. Haha (evil laugh).

heipizhu4 commented 2 years ago

I don't know what happened,

Yairm fixed #7152 with 46b1516159e62840b53abcbe76e3176d0e84e2be, but he fixed 1 and broke 5.

Ouaz commented 2 years ago

4.1.13 Hoy!

- FIXED - Speeds

Details - The new civilopedia category name, "Speeds", is not translated. There's a new "Game Speeds" entry in the translation file though (#6856), which seems unused in-game.

- FIXED - Start year:

Details - Last line in a Civilopedia "Speeds" article.
Ouaz commented 2 years ago

Hallo!

4.1.15

- FIXED - Requires:

Details - In Promotions screen, when choosing a promotion for an unit, "Requires:" is not translated in the description panel.

- FIXED - Trade request

Details - After proposing a trade offer including a luxury resource to a civ, the line "Trade request" is not translated in the Resources overview screen.
Ouaz commented 2 years ago

Ohayô,

4.1.17-patch-1

- FIXED - Invalid input! Please enter a valid number.

Details - In Trade screen, when entering no values for gold trade, the alert is not translated. A slightly different string exists in the translation file "Invalid input! Please enter a different string."

- FIXED - Non-existent city

Details - When a city is a part of an ongoing trade deal, and the same city is destroyed in the meantime, the city name becomes "Non-existent city" in the trade overview screen, and is not translated. The string does not exist in the translation file.