Open Ouaz opened 2 years ago
All "See also" entries in tech screen (There's no problem in civilopedia)
I think the 'see also' should be removed entirely since it says what effect it has
Type
- [ ] Great Person
Details It can be found in civilopedia and new game screen. (3.19.8, apk on Android 11)
That was already in the original post
Sorry i remember that i checked but i didn't delete it from my list
Archery (please read details)
Then just use what you would use for "archery units" as the tech name
@saud2410
Yes, there's several english entries that are used in a different context (in your example, a tech name used as a unit type for promotion), which makes sense in english, but not so much in other languages. We have to be inventive to keep the "same" meaning everywhere in our native language. :sweat_smile:
For example, in french, "gunpowder" (tech) is translated "poudre à canon" (literally "cannonpowder") as we don't have another word for it. So, it looks a bit weird as a unit type in promotion, and I can't change it, because it is the tech name.
So, I did a little trick by translating "Ranged Gunpowder" (untranslatable in french anyway, because we only have "poudre à canon") by "poudre d'artillerie" (literally "artillery powder"), so player should understand that one means "gunpowder melee combat" and the other "gunpowder ranged combat".
It's not perfect (french people don't really say "poudre d'artillerie"), but I think it's the most acceptable workaround.
@yairm210
Thanks for the already done fixes!
@yairm210 I've never expected "willing yes" or smth, but what you say isn't gonna work. It's already Civ5 official translation, and player sees tech more than unit type. Tho i don't know how-to, I'll understand it as "if you want, do it yourself".
But let me ask you something. Does "ranged cold weapon" type exists in Civ5? How does it used?
@Ouaz Thanks for your words, but you never know how much i'm already trying to be "imaginative". Expression always matters. Maybe more than expression. But Koreans have additional characteristics like postpositions. I can't explain how does it feels to other language spreakers, but if you look Korean.properties there's so many ( ) things, and most of them are unnecessary. I always do try to keep in mind "It's already lucky that i can translate it". But if the system seems different from Civ5, imao i have to say "could you-".
but if you look Korean.properties there's so many ( ) things
Haha, me too! For example, english doesn't have gender for words, but french does. So An enemy [unit]
must be translated Un(e) [unit] ennemi(e)
, because in french, [unit] name can be a masculine or feminine word, so the determiner and adjective have to be adapted accordingly.
What I want to say by "imaginative" is that sometimes we are stuck with translation, because english language has a different (and a lot easier imo) grammar and lexical field, that makes things not convenient to translate (especially in videogames, moreover in 4X games).
We have to deal with it, and find the most acceptable way to translate some parts of the game, even if it gives sometimes a not-so-good result in our native language, but making it still easily understable by the player.
And I think what Yairm said was truly a suggestion, not something to be understood as "if you want it, do it yourself". :smile:
3.19.9
- FIXED - type and "when friends", "when allies" (in civilopedia nation articles) - FIXED - units (in Free Speech policy) (my bad!) - FIXED - for (in civilopedia improvements article) - FIXED - Not related to translation, but ressources icons in civilopedia improvement articles are now missing:
3 new strings not translated added. For screenshots, see the top of the list in the opening post:
FIXED - [citySate] gave us a [unitName] as a gift! Notification not translated when Allied City-States occasionally gift Great People
FIXED - City-State Luxuries In statistics screen, when city-state luxuries as gifts give a 50% happiness bonus
FIXED - null in Plantation When choosing a Plantation as tile improvement, description has "null". Note: this line is missing in Plantation civilopedia article.
Can you add a screenshot for the "null in plantation"?
Sorry, now saw your earlier post :)
Following b8d8e11 that fixed "null" in Plantation, it seems it causes another translation problem in the same string :sweat_smile: :
- FIXED - in [Bananas] tiles
(added to opening post)
Note: the line for Plantation bonus: +1 Gold for Cotton, Dyes, Incense, Silk, Spices, Wine, Sugar, Citrus
has disappeared both in Civilopedia and improvement tile building screen, but I think this is intended.
'units cost no maintenance' looks like a you problem:
[amount] units cost no maintenance = [amount] units ne coûtent aucune maintenance
'units cost no maintenance' looks like a you problem
Oh my god, how could have I miss that. I'm so sorry! Shame on me. :sweat:
3.19.10 New batch:
- FIXED - Hurry Construction (+[productionAmount])
- FIXED - National ability
- FIXED - Unit ability
- FIXED - Never appears as a Barbarian unit (the return)
3.19.12
- FIXED - Protected by: [Civ name]
- FIXED - You have won a [type] victory!
3.19.17
The newly introduced strings in construction queue, are not translatable.
- FIXED - Requires a specific building in all cities!
- FIXED - Consumes resources which you are lacking
- FIXED - Requires a specific building in this city!
- FIXED - Requires more population (broken again, was fixed a few releases ago)
4.0.0
-FIXED- Upgrade (old one apparently, that I didn't notice yet)
-FIXED- Followers of this Religion
Finally, all Policy name (Honor, Liberty, Piety, etc.) translations have been removed
I can clarify: The TranslationFileWriter has the ability to look up one level in the Class hierarchy, and we introduced another level with RulesetObject. This is why neither name nor uniques from PolicyBranches are scanned... Fix in testing.
I'm ticking off directly in the first post stuff I've got fixed - in #6421, #6433 or in the branch I'm working on.
@yairm210 "Remove Foreign religions from your own cities" - case is inconsistent IMHO. Change to "Remove foreign religions from your own cities" or "Remove foreign Religions from your own cities" as soon as possible??? Only in the Unique, not the const val removeHeresyAbilityCount
because changing the latter would give a few gamers free uses in existing saves?
4.03
This one was translated before... I can't say when it has been broken.
-FIXED- Revoke protection for
Revoke protection for
True, that needs a Revoke protection for [cityStateName]? =
in template.properties. Go ahead.
So we finally finished this. Great work everyone :)
@yairm210 (sorry, I ping you because I don't know if you will receive a notification, as the issue is now closed)
So we finally finished this. Great work everyone :)
"You spoke too fast, young man". :D
4.0.7
The new "Go To on Map" button in the city-state diplomacy screen, is not translatable:
- FIXED - Go To on Map
4.09
Hello, unfortunately, some fixes didn't work and there's a new one too:
- FIXED - Go to on map (despite 42865bd)
- FIXED - Add all [param] in the capital ([param] = spaceship parts)
Hello!
4.11
- FIXED - Followers of this religion (tied to 7af2748)
4.12
- FIXED - Consumes 1 [resource]
- FIXED - Max zoom out
Consumes 1 [resource]
Ouch - I'll fix
Followers of this religion
Double ouch: "Followers of this Religion" (Unique parameter), "Cities following this religion:" (just the one), "in cities following this religion" (Unique parameter), "Click an icon to see the stats of this religion", "when killed within 4 tiles of a city following this religion", "for each global city following this religion", "Followers of the Majority Religion", etc...
Clearing that will be a SEP, but it confused me to the point I added a template with lower case and colon then added the braces to use the existing translation instead - not seeing the U/l-case difference. I'll leave the template as is and just use it.
Add all [param] in the capital ([param] = spaceship parts)
Will need TranslationFileWriter debugging
togo on map
Trivial to fix
Add all [param] in the capital ([param] = spaceship parts)
@ All Coders: For a Unique-like pattern, a parameter is itself not passed to the translatables result by TranslationFileWriter
, and most UniqueParameterType
s will be OK as the string will be provided elsewhere. One exception would be untyped "Triggers the following global alert: []"
- its only param has been manually added to templates.properties. That could be done with "spaceship parts" as well, close the lid and move on. But IMHO that is not as mod-friendly as could be. I'd actually add the param to the output if the parameter type guessing defaulted to Unkown
(and remove the template for the Patronage Complete alert as it will reappear immediately from that code change)... So a modder using TranslationFileWriter could rejoice that he's asked to translate his "Terraforming module", whatever, automatically. Opinions? Simple or...?
Oye oye,
4.0.13
Sorry to post translation bugs one by one, but... I noticed them one by one.^^ And if I knew how to fix them, I would do it. Big thanks to coders here who take time to fix all of this.
:(
The issue has been closed... but in 4.15, "May buy [baseUnitFilter] units with [stat] for [amount] times their normal Production cost" not translated in Holy Warriors belief article has not been fixed.
See above for screenshot https://github.com/yairm210/Unciv/issues/6131#issuecomment-1120104423
Yeah, I'm annoying! :D
annoying
Pas du tout. You're our official detector. If you look at the timeline, I coded a PR before you added the holy warriors one, and by using the magic words "Fixes # 6131 again" that PR closed this issue automatically when merged. That's just how this ecosystem ticks. Either one of us remembers to double-check... or not.
Hallo!
4.1.3
- FIXED - Wait
Wait
:facepalm: Of course, we discussed clones not words...
Buongiorno a tutti,
4.16
Not a big deal, as these new untranslated strings are outside the "main" game, but in Unciv launch menu.
- FIXED - Friends list
- FIXED - [saveFileName] deleted successfully.
- FIXED - Please input player ID
That's all! Thank you.
The current templates have the help entry as follows:
To add a friend, ask him to send you his player ID.\nClick the 'Add friend' button.\nInsert his player ID and a name for him.\nThen click the 'Add friend' button again.\n\nAfter that you will see him in your friends list.\n\nA new button will appear when creating a new\nmultiplayer game, which allows you to select your friend. =
.. and it works.
Friends list
A matter of case again.
deleted successfully
My bad.
Please input player ID
simply missing template
May buy [baseUnitFilter] units with [stat] for [amount] times their normal Production cost
Now this is tricky - tr still gives {} precedence over [] bypassing all of the normal unique tr stuff...
The current templates have the help entry as follows:
"Too add a friend, [...]"
.. and it works.
Holy... How could have I miss it? I checked 2 times the translation files and yet I missed it 2 times. If I don't translate it, sure it won't work... ^_^' My apologies for the extra work/check!
I found this untranslatble
I wonder if we can get this thread pinned, for it has been updating all the time.
4.1.10
I confirm, thanks to heipizhu4. (Edit: also reported in #7246)
"Consumes n [resource] (n available)" is back. Yet it has been fixed a first time (for "Consumes n [resource]") here : https://github.com/yairm210/Unciv/pull/6705/files#diff-15255a0e8377066182f36febfe1e5e9d14cc3efcfcfaaf04a29ddd1ac132e620
I updated the opening post (+ a bonus one):
- FIXED - Consumes n [resource] (n available) (back from the dead! Fixed a first time in #6705 )
- FIXED - Enter search text
4.1.11
Aloha,
I don't know what happened, but a lot of strings are broken (again), or there was no problem with them before. Let's go.
- FIXED - Add all [param] in capital
- FIXED - Complete [amount] Policy branches
- FIXED - Remove [feature] first - FIXED - Research [tech] first - FIXED - Have this tile inside your empire
That's all... for now. Haha (evil laugh).
I don't know what happened,
Yairm fixed #7152 with 46b1516159e62840b53abcbe76e3176d0e84e2be, but he fixed 1 and broke 5.
4.1.13 Hoy!
- FIXED - Speeds
- FIXED - Start year:
Hallo!
4.1.15
- FIXED - Requires:
- FIXED - Trade request
Ohayô,
4.1.17-patch-1
- FIXED - Invalid input! Please enter a valid number.
- FIXED - Non-existent city
Here's a list of entries which still appear in english when the game is set to another language, either because entries are missing in template.properties (easy to fix) or the game code doesn't allow entries to be translated (harder to fix). There is a screenshot (in french) for each entries under the spoiler tag. Maintainers can edit the message to tick checkboxes when fixed (I think)
- Fixed -
[x] [civName] is able to provide [unitName] once [techName] is researched. (#11397)
Details
In militaristic City-State screen, this bonus line is not translated, although the related entry is in the translation file
[x] City (#11397)
Details
AFAIK, this "unit type" is only used in the "Battering Ram" and "Coastal Raider" civilopedia articles.
It should be added in "Map unit filters" as there's a "Non-City = " entry there.
[x] [Unit] ability (ability)
Details
In Nation picker screen, and in Civilopedia nation articles, the "stats" of an unit ability is not translated. Example: "+ Strength" For the Mohawk Warrior, "+33% strength" is listed two times, as the ability is activated on Jungle and Forest tiles, but only "when fighting in Jungle tiles" is displayed)![](https://github.com/yairm210/Unciv/assets/11946570/c0e6a114-a8aa-4037-8c55-32c7b2541902)
[x] Lost ability (related to https://github.com/yairm210/Unciv/commit/fcd309781df9969831d66c08ed9f41f2046cf8ac#diff-d1d2837aa0e9191070ca9c57ffdd7f2431344a85e7448696ff4ef99c668a3a6bR291)
Details
The "Lost ability" line in the nation description is partially translated (on this screenshot, "Lost ability" and "Strength"). It was correctly translated before 4.6.17.
[x] Upgrade all [...] (n gold) (related to https://github.com/yairm210/Unciv/pull/9485)
Details
When upgrading an unit from the Units overview screen. "Upgrade all" and "gold" not translatable/translated.
[x] Click to choose a file and Overlay opacity (related to https://github.com/yairm210/Unciv/pull/9493)
Details
In the Map Editor options. "Click to choose a file" has been added to the stringtables though, but "Overlay transparency" has been added to template.properties instead of "Overlay opacity".
[x] These [n] players will be ajusted to [n]-[n] actual players by adding random AI's or by randomly omitting AI's
Details
When selecting "Random number of Civilizations" option in new game screen, the info message in Civilizations column is not translatable.
[x] CropYield
Details
In the new "Charts" screen, one of the entry in the drop list is "CropYield" instead of "Crop Yield", therefore it is not translated.
[x] Screen orientation (part of #8822 )
Details
"Screen orientation" is not translatable (Android only obviously). I think adding it to template.properties won't do the trick, but I'm not sure. I could test, but on Android, it requires to create a dummy mod to test an alternate translation file. And I'm lazy. ^^
[x] Sell [value] (partial fix with #8297 )
Details
The "Sell" button is now translated but the gold value is in square brackets ^^
[x] Sell (related to https://github.com/yairm210/Unciv/pull/8167/files#r1051648654 )
Details
The "Sell" button is not translated when selecting a building in the new city screen UI
[x] Tiny ; Small ; Medium ; Large ; Huge (related to https://github.com/yairm210/Unciv/commit/454f99994824f72cea2d4ec84865dddb52ad54a8 )
Details
The new screen size option lines are not translatable. Adding them to the translation file does not fix it.
[x] Great Engineer / Great Scientist / Great Artist / Great Merchant (related to https://github.com/yairm210/Unciv/pull/8180 )
Details
In city screen, in the new Great People submenu, names are not translated
[x] Production / Food / Gold / Science / Culture / Happiness / Faith (related to https://github.com/yairm210/Unciv/pull/8180 )
Details
In city screen, in the new Stats panel, column names are not translated
[x] Base stats ("Base values" should be used, as it is alrealdy in template.properties) (related to https://github.com/yairm210/Unciv/pull/8180 )
Details
In city screen, in the new Stats panel, Base stats is not translated. "Base values" is already in template .properties, but I don't know if I can change the code without breaking something.
[x] Politics ; Show global politics ; Show diagram ; At war with [enemy] ; Friends with [civName] ; [numberOfTurns] Turns Left ; Denounced [otherCiv] ; Allied with [civName] ; + Policy category names (Honor, Liberty, etc).
Details
Most of the new strings in the Politics screen are not translated. "Politics" (for the main button) is missing in template.properties, I think. Besides new strings, Policy names in the table are not translated. The header row, which has two new strings ("Civilization info" and "Relations"), is correctly translated.
[x] Air Sweep
Details
"Air Sweep" button is not translatable in the unit action list and in the battle table.
[x] Non-existent city
Details
When a city is a part of an ongoing trade deal, and the same city is destroyed in the meantime, the city name becomes "Non-existent city" in the trade overview screen, and is not translated. The string does not exist in the translation file.
[x] Invalid input! Please enter a valid number.
Details
In Trade screen, when entering no values for gold trade, the alert is not translated. A slightly different string exists in the translation file "Invalid input! Please enter a different string."
[x] Requires:
Details
In Promotions screen, when choosing a promotion for an unit, "Requires:" is not translated in the description panel.
[x] Trade request
Details
After proposing a trade offer including a luxury resource to a civ, the line "Trade request" is not translated in the Resources overview screen.
[x] Speeds
Details
The new civilopedia category name, "Speeds", is not translated. There's a new "Game Speeds" entry in the translation file though (#6856), which seems unused in-game.
[x] Start year:
Details
Last line in a Civilopedia "Speeds" article.
[x] Add all [param] in capital
Details
In "Our status" screen. This has been already fixed in the past. Broken again. :D
[x] Complete [amount] Policy branches
Details
Still in "Our status" screen.
[x] Remove [feature] first
[x] Research [tech] first
[x] Have this tile inside your empire
Details
When picking an improvement to build with a worker. I think all the requirement infos are not translated anymore (they were before). Below a screenshot with some of them:
[x] Consumes n [resource] (n available) Back from the dead! Fixed a first time in #6705
Details
In the City screen, when choosing an unit to build, in the lower-right info panel. The string already exists in the translation file.
[x] May buy [baseUnitFilter] units with [stat] for [amount] times their normal Production cost
Details
In the Holy Warriors belief article, one of the keys is not translated (stat=Faith), as the sentence itself. String is in the translation file. I think there was no problem before.
[x] Enter search text
Details
In the Mods menu, in Sort and Filter text area, the hint text is not translatable.
[x] Friends list
Details
In "Multiplayer" game menu, the new "Friends list" button is not translated. It is in the stringtables though.
[x] [saveFileName] deleted successfully.
Details
In "Load" game menu, when deleting a save, the "success" line is not translated. It is in the stringtables though.
[x] Please input player ID
Details
In "New Game" menu, when creating a new multiplayer game. I noticed it a long time ago, but never reported it, as it was very minor. The string is not in the translation file.
[x] Wait
Details
The new "Wait" command in unit action list, is not translatable.
[x] Consumes 1 [resource]
Details
In the City screen, when choosing an unit to build, in the lower-right info panel. The string already exists in the translation file, and there was no problem in previous versions.
[x] Max zoom out
Details
In the advanced options menu
[x] Followers of this religion (tied to 7af2748)
Details
In Religion screen, the new line that counts the total number of followers for a religion, is not translated. "Followers of this Religion" exists in the stringtables, but "religion" is not capitalized in the new string code.
[x] Go to on map (despite 42865bd)
Details
New button in the city-state diplomacy screen still not translated
[x] Add all [param] in the capital ([param] = spaceship parts)
Details
In victory conditions screen, "spaceship parts" is not translated
[x] Revoke protection for
Details
In city-state diplomacy screen, when clicking "Revoke protection" button (which is translated), the popup is not translated
![](https://user-images.githubusercontent.com/11946570/161310593-b43f1a94-fb01-498d-bc5d-ada92d19bbd0.png)
Button correctly translated :
Popup not translated :
[x] Upgrade (old one apparently, that I didn't notice yet)
Details
Column title not translatable in Overview - Units screen
[x] Hurry Construction (+[productionAmount])
Details
When a Great Engineer is inside a city and can hurry the current construction, the button is not translated. The line is yet in the translation file. (outside the city -so unavailable button-, the button is translated)
![](https://user-images.githubusercontent.com/11946570/154860674-ede941d7-79aa-4950-a557-999149371fb1.png)
Inside the city - not translated
Outside the city - translated
[x] [CityState] gave us a [GreatPerson] as a gift!
Details
Notification not translated when Allied City-States occasionally gift Great People
[x] City-State Luxuries
Details
In statistics screen, when city-state luxuries as gifts give a 50% happiness bonus
[x] The possible rewards are:
Details
In Ancient Ruins article in civilopedia
[x] Followers
Details
In city screen, when expanding religion tab
[x] Great Person
Details
In Sweden article in civilopedia, Nobel Prize special. "Gain [amount] Influence with a [baseUnitFilter] gift to a City-State".
[x] Remove Foreign religions from your own cities
Details
In Inquisitor article in civilopedia
[x] Type and "When friends" ; "When allies"
Details
In city-state article in civilopedia
[x] Protected by: [Civ name]
Details
In city-state diplomacy screen, names of the civs protecting a city-state are not translated. In this example, The Huns and Ethiopia.
[x] Enemy Land
Details
In Just War belief article in civilopedia
[x] Followers of this Religion
Details
In some belief descriptions (Asceticism, Choral Music, Liturgical Drama, Religious Center) using the new string (in cities with at least [amount] [populationFilter])
[x] unimproved
Details
In Celts article in civilopedia, Druidic Lore special
[x] Requires more population (broken again, was fixed a few release ago)
Details
In construction list, in city screen
[x] Requires a specific building in all cities!
Details
In construction queue
[x] Consumes resources which you are lacking
Details
In construction queue
[x] Requires a specific building in this city!
Details
In construction queue
[x] You have won a [type] victory!
Details
When winning a game, in Global status screen, the line saying which type of victory has been achieved, is not translated (only the type actually, not the full sentence). There's some corresponding lines in the translation file, but without the [type] key.
[x] National ability
Details
National ability combat bonus in battle table
[x] Unit ability
Details
Unit ability combat bonus in battle table. Like "National ability", this line exists in the translation file.
[x] Never appears as a Barbarian unit (the return)
Details
Follows 7887e7a . "Never appears as a Barbarian unit" has been removed from tech descriptions, but still appears when selecting a unit to build (like the Knight) in the city construction screen
[x] "Pantheon" ; "Founder" ; "Follower" ; "Enhancer"
Details
For belief type, in any belief article in civilopedia
[x] Great Admiral
Details
In Naval Tradition policy in civilopedia
[x] in [Bananas] tiles
Details
When choosing a Plantation as tile improvement, description has some part untranslated and unformatted. Follows the fix for "null" in Plantation (b8d8e11) . Note: this line is displayed correctly in Plantation civilopedia article.
[x] units (my bad!)
Details
In Free Speech policy article in civilopedia
[x] Notified of new Barbarian encampments
Details
In Honor policy article in civilopedia
[x] from every
Details
When founding a Pantheon and choosing a belief, Goddess of Festivals. The corresponding entries is yet correctly translated in civilopedia
[x] for
Details
In any civilopedia article. Exists in translation file ("for = pour" in french), but it is not in template.properties
[x] "null" in Plantation
Details
When choosing a Plantation as tile improvement, description has "null". Note: this line is missing in Plantation civilopedia article.
[x] Religious
Details
In city-state screen, when type is "religious"
[x] Requires
Details
In any policy article in civilopedia
[x] Never appears as a Barbarian unit
Details
In any tech article in civilopedia, with a non-barbarian unit
[x] when fighting in [tileFilter] tiles
Details
In battle table. Exists in translation files, [tileFilter] is translated, but not "when fighting in [...] tiles"
[x] Policy
Details
In battle table
[x] Resources
Details
In city-state screen
[x] Amphitheatre
Details
This one happens both in english and french in Liturgical Drama belief article in civilopedia. [param] entry is not translatable.
[x] all healing effects doubled - This is not a problem in the base game, and instead results from misspelling in a mod, the A should be capitalized
Details
Fountain of Youth article in civilopedia. [comment] entry is not translatable.
[x] Choose a religion
Details
Button "Choose a religion" when founding a religion
[x] Religion names are not translated when founding a religion, although being in the translation file.
Details
All religions names - Buddhism, Islam, etc. - not translated in "Found a religion" screen
[x] Enhance Religion
Details
Button "Enhance religion" in the main UI on the map
[x] null for Wheat
In Farm article in civilopedia, bonus for Farm builded on wheat, appears as "null". Happens both in english and french.
Details
[x] various bonus/penalties entries in battle table
Details
In battle table
[x] building/policy/tech names (as bonus) in expanded stats drilldown
Details
In a city screen, when expanding the stats drilldown
Reported by @saud2410
- Fixed - Finally, all Policy name (Honor, Liberty, Piety, etc.) translations have been removed in 3.19.2. I think it is intended, and the translation entries will come back in a future release, according the guidelines. EDIT: Strings are back in 4.0.1.
The list is complete, I hope it won't be too boring to fix. :p