Mod bug: Crashes when selecting unit

Caballero-Arepa commented 1 year ago

I'm making this rework for the mod, but when selecting the "Berraco" unit the game instantly crashes.

Here is the code, there should be no problem in it imagen

Here is the crash log:

**Platform:** Desktop **Version:** 4.5.8 (Build 832) **Rulesets:** [Naciones pa deciv ES, The Undead, Victoria II Music, Warfare Expanded Unciv Bucketeer, capture GP, Tech Stopper _WW1_, Bamboo Deciv Expans, Civilization 6 Mod, Community Maps, DeCiv Redux, 3rd and 4th Unique Component, Thin Bubbly Borders, Barbarian xp farm, Uncivilized Enhancer, DeityPlus Difficulty, Tech Stopper _Renaissance _, Latin American_Civs, Tech Stopper _Medieval_, Warfare Expanded Lite, Star Wars for Alpha Frontier, Community Civs, Better ruins Lite, Only Mod Civilizations, Tech Stopper _Classical_, Tech Stopper _Industrial_, Difficulty_Sandbox, More Fauna And Flora, Honor Wonders, Civ V - Vanilla, Civ5Nations, Civ style set by Bucketeer, Sheep Meta, Resource Recyclers, Epic of Fantasy, hexatopia, Dreams of Steam, Alpha Frontier, CS Rework, Smoky Skies Redux, Naciones pa Unciv ES, Civ V - Gods & Kings, Latam_Civs Beta, Closer Cities Distance of 1, The Barbarians, Fantasia] **Last Screen:** `com.unciv.ui.screens.worldscreen.WorldScreen` -------------------------------- OS: Windows 10 Java: Oracle Corporation 25.232-b09 Max Memory: 910 MB -------------------------------- **Message:** ``` java.lang.IndexOutOfBoundsException: Index: 1, Size: 1 at java.util.Collections$SingletonList.get(Collections.java:4817) at com.unciv.ui.screens.worldscreen.unit.actions.UnitActions.getImprovementConstructionActions(UnitActions.kt:490) at com.unciv.ui.screens.worldscreen.unit.actions.UnitActions.getNormalActions(UnitActions.kt:55) at com.unciv.ui.screens.worldscreen.unit.actions.UnitActions.getUnitActions(UnitActions.kt:36) at com.unciv.ui.screens.worldscreen.unit.actions.UnitActionsTable.update(UnitActionsTable.kt:25) at com.unciv.ui.screens.worldscreen.WorldScreen.update(WorldScreen.kt:398) at com.unciv.ui.screens.worldscreen.WorldScreen.render(WorldScreen.kt:723) at com.badlogic.gdx.Game.render(Game.java:48) at com.unciv.UncivGame.access$render$s2211858(UncivGame.kt:125) at com.unciv.UncivGame$wrappedCrashHandlingRender$1.invoke(UncivGame.kt:143) at com.unciv.UncivGame$wrappedCrashHandlingRender$1.invoke(UncivGame.kt:143) at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandling$1.invoke(CrashHandlingExtensions.kt:17) at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandlingUnit$1.invoke(CrashHandlingExtensions.kt:33) at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandlingUnit$1.invoke(CrashHandlingExtensions.kt:33) at com.unciv.UncivGame.render(UncivGame.kt:454) at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Window.update(Lwjgl3Window.java:387) at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:192) at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.(Lwjgl3Application.java:166) at com.unciv.app.desktop.DesktopLauncher.main(DesktopLauncher.kt:76) ``` **Save Mods:** ``` [Civ V - Gods & Kings, Barbarian xp farm, Community Civs] ``` **Save Data:**

Show Saved Game

``` H4sIAAAAAAAAAO1da3PbSHb9K8x+SVJFOATf5DdZHo+dHY8Vy7tOyqUPMAmJWIMAA4K2NS7/9zQepEjgNvqe26DtyWq3yiNR7Aca3X3OffTpr5/8ZBvE0fxrtFt/8JP5oLtIfC/1l++CdDX/mvpf0vnwyejJtFt+YTrof/vWXQSfgjD4w0tV2e38/Vf1++/e2p8/9ZIPXhJ40bab+gtVwbfuJg6DReBvs5/V1y5VgTTZLYqS6rP/3fnb9JUXeXeqdvV74ofBnfrj0Ud3cbj0o4u7opK7rINXfrwJ/exXf7tR31ZfPSrwKVikcXJ/XOsuiLZHv6ee6sHCCy9e5nV82YRx4i/f+Hf5YHzrrrztL2psXn+O/OXrRHUo8sJLbxOkXji/9cKt/637dRN6937y9n7jz1/s1l6U93M+nnT3o/Fst1jdd+LbzkXib7xoGXjlqGT/bt/4W99LFit/OX//LPHWXkd9pXMV+2ly371KgigNorvOVeJvt93XG9XbbfeVl678tZf//OsuCJfb7sUi3m3LPy5WQeSrwq+CSBXt/hKpbvt+kv187an3lX223C3yt9a9yJpWX77cJYkfLVSTcZpmH1zcJcFiF6a7xO++TOKo8y5OPmZlf91Fm/jz0k+6b1d+HMZ3qiVfDUjn0tumeeWLOIrXWV+O33L3d+9TcPfQaKCePq/80gv9aOkl3adelDfwytvGkerBder7oapjvfHUs7+Ik63/wVt87LwJltnXrlb326yRt4m32WQfXKpBCbbZsD1V/f3DP/T4chV88kL1uepw590qq/UiCtaqyy922w9quNWf3iVB3vnLbEp3rv1ETR6/eLBwl6hnvFoFYbyNNys1NKqR7BHvb47n9TbN5s5lMWTz/nja3a7iXbh8vfGjq+xb91fB4qOad2pE/J9pEWyS+EuwDtL7+denfniXeEt//nsc+d2/e5GaVmr+F79eq/HxNuohi19f/at6YX94zl/j6C4uPlIDHXnFjxdR+tlPNuUvoZqt9+V3vFX8MSi/9TxRTRT1VRdjFKfBbbA47C35HvSX/WrJltP7cqredNQy7SzUPAl9tWX9y1+6wSIvc5166cvsx/+4Vq9INbSf3DddLx/0+ddFqObWXJV9sovUG3mipnOweHK8rz15q1bpRTGFswWbL+myHrUFUv2qTi6gg7Witj2tVqjrcrENID0tS1h3sKhH069iDwO6VRaw7VVRjaZT5S4K9GpfwrZbZT2afu13UqBjhyK2PdtXpOlaub0CPduXsO1YWY+mX3vwADp2KGLbs31Fuq7twQrp26GMdef2NekWZgHSyMosS1gvzaIeTb9OoR/oXqWgbS9Pq3vo7P/EO9WnT37HjxSC+MuOonJq5WaNZNjX8RPvpqGbN4eK3l8FfqrGPycg950PGZKuOrsojBXJIJ+0pCY39MAV3BIYsLKA7UAV1WjeZpX0Ad2rFbXtaLVC7cI4kHNocTyUsl8gh7p0QHFEPBGwOC5mDRhHlWm6+UC5EYr3UMia5R2q0nSwaq8B3awVte1stULdqy/tPOS174tYv/KyIk3XjgxVoHfHpWw7eFSXpo/HljDQyZNitr08rswELK/8ZeB/wnDFy6xbZRxaYYvaY9ZrP1nY1VIlRLm7AeNDRZEW6FBekW5VHXsNkKV1Us56fR3Xpulp4S8CulgWsO1bUY0OM4/9RwhqnpSzxs3j2rTImXujINAsStjjZV6Pbu/cO/SQnfNQxnrf3NekG7XSAYcM276I9biVFWnpWukuhcjavow9VStr0jKg3McJ0Z+ihD33yevReUBSzC4tvm/t/UhP7FEa8d74kRdst5lfEQC9N3mrXhhs1+0B1oOfGHCrHcpYO9b2NelcfvuQAdK7Qxnr3u1r0tnxRTAAMeDLEtaWe1GPbkWeRGSQhXla0Hp9nlSnBfsyVAPh/b6MPeSXNWl69xAQArp3VMi2fw9VNTjF92Eq0DN+KNaGe3xfmQ779/E2BPsPZayxf19TE7fLQ2gosSsKtcLq8qq05KQMG0LsZF/Gnp6UNZlw7WW0VBtmEkC23PPE95exHaS9v9il8SLxFnbOxvevk3wjElRx010EaRZjff9VfdsrxvvLfNq9nzvTb91gOZ+5njv2x0tn6vq3zrA3cJ0P097I8T4sB6OB63m3k343ysdbDWqixjCPxXdv412U+fKU5USF6TfxZheW7R39POhuN/4iyNhCehHuu7Sdf937D/az4R/eJ+9J6EV3T16qV3nnJ11FRXf+3P2WJ0+k95UI8AdlJKVPM0tJ9Uk97qs42q1Vh7sX643aBVZZSkbSvfJCT83B34K7VbpSKOp3M2fAdhVv1GdqXJP77q9qdLP/vvKSj36qbJAw3m793VqBZKLe5Ee17BdHTf/Xzle9ev97nK4yBM0zIbyoyAh5iEKfRJjz7IkgzF/Kw6tQP06yH2f5j7Psx0n+4/Th0+nDp7NKsal61Z/Vs/jLt6dVn5S86QbbajJGHlPfz5PLIndl7tYyOtJ485t/m2azp99TtalufIjTNF6/yQYz+9gdZI2M1ftRbzC99v3o5XqTxJ/87D3UV/k/tmpdv/C2q1fe5u9+Fmnvd7MZls/Wk5GpzojrNM/IKCbEpZoLnUW+3r/d3DTnnRTpA1+rWSZ57P0xseQxseSnTCypb65l0kfkqafywndxpF58vuXtorTzVzWd1KK6aSVBq7pSiqSTx6XyuFT+PyyVazXlg/MslDKH63GlPK6UP9dKsV4MOTnPLBH/Si213DGoGnyuaF20DO8f/qqWQ7xLFllCoPo39IKIWEaHvMnHhfS4kP5pFxJrqZzkFD8ul8fl8k+7XI5x50W8zVwtD3/8WxSoQVD/pvM3mQer81ZNCorA5Xn3j+vocR09riPV4MskKcO85FK6Vj1f+wmxjvbHYh5X0uNKelxJ5pV0pUgcuZDKw1+P6+hxHT2uo5N1RCyWw/HLx+XyuFwel8uRA+7bTffDQWIgq28Z3N7m008tqfU6TlQ9eXT6lbeZf117mytPLRU/zdzmX9PspH4+pTZ+6N3Fatw99ckbNb+86G4XqqmlSlwHf6gxUqQv2G2zWPHnYJmu5sNhd+XnoeL+rMgnyBLsd+tvWZG9h2OrmKRa1uphF52nXpgHmz7HSbh8p6Ze/jqP1RX+Xkov5PIKnX/Lo/+d6aD/792tn8Wwx5PpbDAaDWcj1WQecVcj8jSI174adG/u9lTTXy5jtZh++ZL6RdB+qHaM9cZPsoCBrz5Osui12hHmvSejWf6/sZosRW/fBItV+Te3P+p+zlIM3q7UX1fZdtR70hsXgf7f1FqZv/+6ibfBPgHDyWPl/dE39Ta2/ltfbWZBNM/7cqh+/jzYrrqrIJvuasZkWS4nVfTzKoanVbxe+F7UUMjNCw2odjWFsu/3T7//VhnOSUZF8l+f+/lgbefvn6upuk1vHp7gmdoNj+rNMifU2s/SASaVjhX9coF+fZkXA9CDyuTj7s6oMvu19vR+/n5vttzoaxrmNU35NTHf6yivdyKo93UQHn65WGchLtVJbTvjvJ1xCyORJ6C45FzWlsmTO9whVCbPeXGRufslW+RZoT5WKJ+NLjYb3Xw6uth0LHJmyOmoLzMsE2OQMqMydQgpMy7yeZD9xc3nAjkVarvFRRqHYcO0cvM5gk0RN58jA6jPeTqTg82QfjFDsHb62NezqQG2kM0M8kFqg/9y0bSi+9l0IRcaWFGJc9hLLJENW+glstFIddgir9NMO4WBSAQalXUBcNYTwuZ1EH7ktdOn4Azp6IBCsassxrQ1wU1uJ2ybEKeh3SGFcs+UhZaY4aeh2lFroDYWgNpED2rw7jcVgN1MgnU9CuvKGWB41336pfRoOAWRsU8gY7Vb77K8XmYnBgRq/poog1eZGUtmHUMCRR/qqL3jF0H2io8n3sExoZnPtRZHBAbX5zNZLQnnIwpQ4KomWmTWVCXkqAUFABnfTAvnwl4UBAGEYpQb4GA/qIM9hx+0Aes5P6i8/+so/twNjjK+L6LsUEXayb0g9HTP9tdTFB9KjNoBxRdMhfoUX+CRDJd4ciankFIC1bHalJ0AXKTKEX7zPvrbhhfcQAsAXjGRVzDUI7nBdMYwe0xhtmHuTATYPNVjM9MxMDs/UPf0QI2bb64ewGuV/ecuugv9U6ysu0iP1sPbZHd7G/qayVR7sD4B/tWhy3zv0oEbEMQgTzJWP+DwOmwP9Edae1zGHxDQN/AHcr+Gq5oSaG9yUswEeN4D4R/H877OeG+mANg2lFMAnoVisOyHEiN9IAHdvg3oHkCbRt7D6r8Id+sg2q2rO8CAiewaI1yL7AB0m63zQ540s94+hc4PhoxN1QMKtx+qxj0xeyqAwfpI4F8e62EdRr+JwBSfNgC8CRhZMDWj4L3Bfn3lJdlJsnOBco8gCPQkFD9xQULMC0jeQJ9A/iaeS1OHcavUYcR+w40eCpmnL3vA4uy+F+UpTV/jz5GfHOVkxGXY+nXl8zwqfO2naah+WeRpEumrvTXZz6Ln6/gQwV+Xf3jlr+PizDBBfIbfvuWZA/XPTX5H2FEz1noqTKPbzPoLrkQSHBlXwlhJFdY4sRTUU4L7Mfo63sMc1Jw4YTZfTpxI75meuIwkfokhRZF4HhAsYOlI4ucO6U1ogewQRMdUqw1NcUUMqNFWHCPcS0uQTC1bRV0GFJMyOMFpNoYxq5GeWTFX7FjApyb6KD4f+0mO1jszRxOTIjlk15nZOVmTq2dNLdIy7SJj8CB50wOCglkSOpqvCNnc9cr3N0j4acAeRmpnprrw7J5tJIy10RyZ1wlM6pmCbAmnPz2c/rh1+sNhTCDhGdQJj4kcjPTuHW5W45BiMjz6g7noHDJ3gkd/zkxUKPPp4Sj8qfn08Hl75lNBjU5Np7M5jNxmPoQOqiD3tN/MirTBijaCcwMBmxoKwk8jAX8an4E/TRr4U9uovFaLKPWS++NlREjVna4n4gtFtvpu+9FPs0vqLD0TpSpbtrqodS7uYHYGw95vctQ74mN0hbDpKpGQMekmsbfUPvPhrfeoqru/3/w5ZkOp4/eTzoaj3hEfS22UVl9r3W45p1nhYmYFhVWWNs2oza3TGP2aIjbPkN+1LtdSoKBVE5Kjs/UGZKckjhzaOAKzLccCG2SC2SBT2AbJzRbQBunhNoiL2yB92Omamy3YoQVnLHG5jiSGylBiqDScWRJmNDpkfled2lG8GmyJdLQ2tqSpi7ASkGwi6lEugzTZMfPRXEEQui8g9wOK3BtmyFBA7kdnIPdjffoYVOfPSdUmZyLuLUU8JzRznxDMHUbmRu5wGW82qvs/MVt/mj3oIj4Zz/++yrOPOeZQnQBPGwmwkIwd504fqVpbDezln8kMmvy0a+uoe8THEnPj3EYQjZQtGkHGnFIIOQrbBjzrOdCmXBjCKSBnHwk4u+DYLMjZp3C6aE7zwXTRHs7ZXZyz9+uc3eSIH0vo90hCv4cU/eZxduyQtkOmZUq48oF3G5PIebwbo70uRXtNU0Dg0x4IaO+Qor1Yemp1PxxZpARITjKO9YzuZ3OV467nOtea6HMRbL1eRST8fFA8JfgBDygt+0TllBi3Agywe2cgAa6ABPQJEmCCzoGABAy1JICbyNks9gMejB3XCYPRjYgThqllnmXOOLAXmjMOkD64sMsvZxyYX9WZSBjHWMI4RhLGQeoR8WgKOBBkBiMvcaINZRjcp+YKfGp9PblgTv6B3sNmoCdQeFyS1zUCnUItRbDGBJQXB5Ht8glYeSniXk8bY35ssmERaZqdAWt7Aqx1BQZ3X4C1A4HBTQcfyeEdUAZ+pblDwmYzBPfhUpM6pDJKTes4mh+A1KxW3mPP4AS/HJzJjV8qreHWcdiEJBMJpI4lkDqSQCqpbITlQJJnKHmobNwlTu4JMTsQjOe9efVpjXtJ11yB3d+nwNi88AYUHpfp16yte0ggbXP6Nh/AAaMYj+pYwNW4EZPPmyQzad/UnWrRV1tkpgVXruHU0+euaAeQkfo6JSEdhOc+Ac/lnG5O6OPBEvOpa1m4avNQ/+di/rCO+awFxGcUTNFcBLHHdfLQXC3HOKi1MqmTjTY6P63TjXY4zJiolFX6cJGxdJnm9AXkB1MJfZlI6MtYQl9I+WEe5wE9AuRhRAvCQmbbgLhTaYyxo9YUzEhnA+Gf1zX18pNqg9MWQYKIg+zaZvj4Xn1EUh25iRRVKyCVkplkbIaWotSSz+RRwQwZSl6Zc6LVRjSeklQ2LG5KUZmlKSrS3AaZCH8O1mmGlgDwCURfSFX0Ar8kk6Ahn08ZIDCXnGoiKYTuCGyzl4MCc2uGgC3MnBaAofupBKAnEoAeSwCa1EXmoXp7AN1w1o1bH5Ucdnrz6WmI+vRvbaaEOfuMhWq82iFTGaDsQO0ImHkHc0cytsnBwDodoTnBd6EjtI8G2TlIlkK7bljlKcFpTvjHxiCh5KINy1wvC91MQzAWIRBy1us4G4gHmEgnuOYDLEIoNRtEV0i28X0cI4S0M0w4RhblJ3USwKQOEx7NwTw5szoXAB0M5MGdWq9MgoLOTMIwphKGMZEwDPI6IR4tAVW1SAGiuiIaSEsg2UcL/4R2H7DAaEjsR0McAF8or1PAyc06kdBqVPIZgQVyN6hF85G/GcavfC8JGwTY9RLQzdgvED/HkgD00s3N2I8BOaXQbMR+3N9glc+H6zW7uF6zS+g1Q3A6soTjcR2Oq9LJeucoCe46mfRmcCfThvRFZnXgzWH70Om/JV4U1A+8awTfqw9SorHE9Y8C60QCrOTtRTw0Bu/eaBCjsUBjo+AXiLrGc646FBOddgbyBWrQpxVZeQBWL3NgAEjIP6gIRJJJzNQG/fmwSR9cY5WntI85mClQCccAkJLwZWmBY4563FQGERZX6nW1Sr3NIAkmJhLavDBI0iBHEmAwGWAsAr2JjeGZQyaFf3yjt7qLGRDXKX0vJCTWRtFwt8RMApRTCVCSd9fy0BUESlIDl4eu4H0ZksRzR3J7rUMZWkaLttHnq+FfNZjELvIjYdHmHr/LVRDpUtJIZDSfx0aqpCRmQTk2pDlKg5bOgC9rFXEVSmuWg8UYIlEisCb7FY6Xgx5oQgKWA8XgqTdCApYDxTSuSpXDSMe2wb681p/FJZGc6QdGE++mIginQNiqK1MCm/nQvodpEFtnEmydSrC14Q5dEyCDd1GRkqg8QJbIE1ffGSufX6JObKNLU92/kehvC3hq7zwusd1G+V08BiXUa3HZCu3p801WiK5NUZDWKhBE1OshMt2w2EaGayPi0oguLo3oEtKInDg0qMtBSCNyLOtJ2xA2EqHp+BxoOrFC0wKM2TcT1sGYVEc0IUMJ4SAazyRoPJWgseR6XEdywYvTIGLIPWtHnrhmWdggNlNBxbofurbdkhDPOvBcxTE4SkyJwuSVVpLsis/aFITLEVwnBmfoQls3IIzrFyDwWYXE4v5xw12SppF0yNsRGz/qA/Hxd+NzP/I1lCp41SGgxPGshgA02klCagz5mbYyvRQfUotAnA8DTlyaD1fmI4T5OCQT80C7uDCfiwvz5SQTy7fPSSaWKJtTyNbJ4FhHBiVpyjTVtOIqboOon5EugsxvJmF+U4r5mfIwGcHmPk0xQbbYcJ+NiWKC/JA69S+QgADTS6gQvHZDtcpwMB6wrzZCpbv9UHop5jpt0csq0YFIDnV09aenl8MfOuQnnSA+prxrCK1nnO0TvoXrRbxLDQ9/9PP7l3eR6lun7HxnEauZwmOegx9rABz1gfiY9YK0Wiewv9WamOoFIyF6C3tTMa6Ki0JqNSEb2S3o3CREIDkR0WZpKkY+L0hcBzhxHdaJK4frotnNYy3ZbA5X0pyqts4M+TuuTCKS1IhkekNBpjqTMFUeN51S3LQpHU3DbkGiSl6+QqSPQm7AbFgJPgy6PikJBlbMVCJMSlr3uIvVeOyZquaHUloxv2oDvQlqxadVf2qfnUuzFkorE35+ftDZ5lgZzI3os2JN769B3r4Wmob2FkK6k3HeGU8ZwxgPIdfZdAjAJQgTfc+jJHeyWrurFfFsJlfgNYR9nBsNcG401HIjLu0b6UK4iCtxRvKvfsu17nmVjQLQnmWBfKlkWWBQd2ZNhaYUFeIfQNNQK9CdR924wfIbkvO/NgOMR7+tZSEc6mgNK2AtokF1NtVm8EosFVIH5EPWCdFelPXIC9/F0TITksm+2fmrF4TeyUCbEtHEeiy2WWhsjObBPjR1CG1NBozjiWNYrwhZS1g7bWQH6sz7S2uREb1PkQR30ItBiFhyks9ApB4QSG3iEEOBF2N0DuQt8HzQOp43aGAavSsogktuwdjjvs09GCULAN0Z02Z3hmbYOdslzQm0p5h4dVBXW/B7+6u/1pxxrTUkEJp0BGISDnXEiMUYkHNCLOxxvpcpzYdr2wNVlNbl+c6fkc/EtvZtMhYIjUwGEcDPgFnY2oRSJVKckKxsGmCKFNDHlfhoP7Uo7+I43tda3LBhU3AC8LDcUBulMHCCc6E3isOkPqQRh0l5RyZ6g9A7o6DXwuaeNuJr60guRmGkJeqOC5ZLAIRhgaaFQ50XYkE3qlkqMU6dBrO4DUEzAbDyIFuOorhiJCEYyTC5yS3lhDV4q/hj410nhPgj4fIxVkNoQFYvCAG8OBRkg5Y0G8vp29zZWG6DxVqtSK4n2xVY2H0BAg8ECDwkEJiF2ii6kuqQOdYH602yj/FdRItA/beT7PSvt35aq0Epku19J1UgmegP4niJ/qCze9aCNTzVOr/17VI3OVZxoSGMSCM0iLYCCUWHEsdgJTeAsRQqzGt/j4VGDRRpRlvv2bmEWcLRJLOJazgSEo4SoCVkHSVAS6g7Yn6EfQvC9CAC90Fkbu4NptJIEQULQCdkJ0E5PooiSGTaJNKmEllz8KD7QAvqXMoyJCDeCIYNkpOwC2IP6uBRErdBVtII46jIVk8Qfp4JEHiqR2DA/AYhV3D9gEOpNrKEW0DIpRLB5ZcE1qC2IU7LxGqIpVXtZHCDqCMl4wZ18yFRI8Rp5SB1a91cPZkjWXyzmjBYftrmOZRCrLKaL0hIWKIHgOrP2gBFhOSl7s6U19422Nq0RQhgasJCULWEQqZhCVAIX9lYBWphFMpr3Kc21RZUQCDZahW9LYgBeDh5gMN6QQXQ3H9SVBP27Ls1JHNJ4U29sgtRg0iF0yVlOHnuAfBqkIJWgBRh1rKRPhUwBv0liAaWIRFsBRkDpWkg8k3WsL4h8bpN898iWOwQ5ngbvndYG1NnoTcyFeN9MjymYs6XrNm45hC6+bg1y1FgdyV7veP8rDRCPtP6ZBJBBsza+dd6KVGKG5wBxWcCEO8JbHNX4HDva2G79sTNBwALAiADc9vUPS2Yo1BMqnbyAByV7aR0O8G4Qo9A5mrMnpB60Ihq1sZwRgC1bHOnOQAdLTQh2yVfJpR2Vkh0ZsHMDYEopkOdHYegmM6W47sltDDOcnuSzAAZAo3jQKhZQohrMggBH8kbCYH5OCorVmCWdanBMzZIhCYnI/GOgbhB+EmXKURhOLjhUgKcDDkCNHzdExjBbmto2sfRtEBgUCLUJUU420BgUqizPWhHQVqi3+nqBTxNyG6A5Wsv5NrLBcyfB4dnchxGMuemBO42ZdzSwC2+rvN54kXN4hXUpRL1/dZcj16ZEKsH5CjanO3m1AKrEx6oyQ1LF9bxmIHgmF8J1y0kZAsNvSJUCxkga3W+mVId5IikY+bmzBwJBjlbT+BCdgU42ZfjpJ2Wo0hY0KWUBY3d1d9Er9sxTTAIZj67etVAk0mrjYkBoEajjb3ROkDqbd70jYDXAiDp71oAga0FTNOBFFaNNk8aq4aIVNftNHM1qJ0Jq/HqzMlGFMRkOwhFM0MJQtCMgYLgxieQM9OrmTUDH2blzQQw1RPAlIvDVAFt6N0SpPaYPvA51mAjimsSWTFXoivm6i9nN4GeSM6Ovj7NCnsKYIS0tQCw5Ehk7PdCSiPjOoi8AEHR/tlQlJIFKwpV0nzKD4+EwXz7PJ9Sa6aW6eNQVxDiTy05PG4MJPKsWjZyC8m/oz03jNMDYwYajx4Yc7V59ADZ9VGwxzW6CIkuBj3AwJ4S6OLwA1zUDTRZJzjYT3GwnwmwvifAeleO9ShUU2pYvNgu6jzV614J7FaJBJZLaWA1Q7jIJ+pKRMgRsgDEA2lW8JOB9HfRRC81aLSyqsZetiOLftwN6nONf+RPxZTkY9xSUnbZhcpHWJilkQEZtoMf/AIK4fgf/hIeukF8zDZ3yAsAfvYlUCjg/fA38NAN4mMInhpXw1MvUv9vQKAf/DYKOYXaMBAqC4ZdQTYXa1aMWEgb3Ydqhg/b2YvEChFyCwsPw0YNIWbIMINA3kxJGXLsIMyooWQKOXYQZtRMcaNmJrBperhNU9hBqEuQ1BrkWU+oy5LSCeQZT6jLUiL651Kqf624LClpQEZ66gQyoCCNQMR8AqEPsKus3YBMRyvg1D2ZHj/aMLDjpS0ZYBOalhI3g9qwAaZD9yewFCx4aktvZEzTVOJuB0L4Gls6hCIlomlRJ2CbYOFzfS+ETIjQwq9Ryhai+ESSlRHLdFlWLPqIMjtc3lKvbtlMBrHYtEDDkpKw5ATNMWY3wZndFGd2MwGx64mJHUrRKBFJXkYY6n+XCEK6ekVInVP8eFFfROlnP9mYPeU0V2MQE6IFMzNElSdtGqQEKNG0slJa7buD/ymBlJK6mhfZfFlErZ/QYU0ypU18NUatL8BlSKRMnHb2wa1qFCxJUoHdidKCIwmTGOFPWZvhJ45IcbLVUWMY9Amh/iBKeZNDNGjr72EviMNl53WiO7BcPT5F6XJWq7wId+sgqiuqaU5N1trQ63jCIVlK3pPj3sLoyQSnJ1OcnsxwdlIwGjSOTqlz8mgQymgoPU4eDUJNAkp1s55/y2EulBZn3bBhc6BWWIksIcD6UkcRK2pFvYMgSwjSi8Zr9j0ihDXaZM1g+GRJfP2JVQCIuFtDFAXnkyJUzJTPfAT334AsA7/x0iEcFAZiggp8a50TwtxMSicUOvmkFw1tdpcI7oXFmMIYZwoTnClMcaYwExMFkb9ElEVIri5p+q9LiYLKcJySCm2oqWEOU+7uslzF373/tNXEDLcUMK35vF1K2ZSPDyhPoDRRaYO5Pqh2PgOX0ku15GQ2NrzGerMPN1bqPfh19NN8VicjFt6gM4RRibs3W4J24qoR1JlHSKGe59IgQsjFRjyROKuHPjp+j6cD3zKCXzCC570IREopjVIOD8GUJ0c4qRjjpGKCk4opTiryXQbMkulTKqM88oLyEEpLlEde0PtX9WqiInpiPKLEdn2IDdI6Mjb7HnVyt9+LhYASq4enwu6ToL0kOng+PQz5Wg3fcy9IV7e7sOm99erQ3aKejzBZle8CQUFdhJvEHZ1yGX6SQWjhn88gbC5OIJRkqsTANsgCojyVB8HJ7YCgHlc1xWFer2nazAww38EQh/kRDvNjHOYnOMxPxTCPIjYlKsqDeVRalhL75AUzjLogbJg3HmiugzDqN2nQDT2HKwCxfw/PRGm2stN8CW3SM0jUuYReaWuxEDkqH54FuHt3Jk804JMAAJsRhwHzJrF91jX/cFEN/rUn/R5mbYPcLUkHaDjXdp7PE0Agp46qGHdzFMj34I+gOS6oiiO5QDhVoJs6xJF8hCP5GEfyCY7kOfiDr75PiZzyGAMK/pRGKY8xoOBPqYzyGAOo9e3qdUKbkL79LdcllEOr6UPX+vsTaLCGdAMAdD7HVeU0WJ9BPHCmxcyWQiVTPnrWyIX+Vg8SpLXQyUdfMGaOi6g6lAgNJtdJJfmzYBQzcB3YwsXl53BMFGikDnBMHOKYOMIxcYxj4kSMiSC89SnFUx4movBG6ZfyMNFOKFqvQdqEkCg41oGMdfIVRW7tDZcNZQiRUJYQLjgGszoCcK5/lR/NKuEA3MuJOyQ42z9q0AgO3ztUNjVrx0dXFWrW4IJi+PYtkA4d4Nv3EN++R/j2Pca373zHR989pRFaFKqRrub7PkrwAHGgT6mC8sADnbGUbCdTbA41qMDva9UpDWiBPoxWWdKAFujrwS8+KNACHLeZbutvRgtwsyeu6OPgA7rZC+QjHepALgsgwKUjiEY5MGHHlVbw3b6P7/YDfLcf4rv9CN/tx+Ldnnwrst0enBR9StaRt9ujex0lM2je7QWeM9gsEFB2QsGLtdmTlJ1t9WiFtAxbv+TGDONNcRfh2kvvm2bkTLe3Y9UQt6tLqhHcCucI7gtwBHJbDnUckoUb6HLHnTYOTPtxUQYcBPo4CAxwEBjiIDDCQSDHDZQAUApbQtygNLVsIAh9FEoaiwdBKJq0dXcRodjESvaUhHRQ84CQ+mE5regb+zgRmyGJU2OyPiTeUa+XUP0B0lJqCNHYVq8OXnhbnHBRrelZHe8a4lKvvGS7MrTOV8SrdYa6vhw+ElvrEJC8U+sRdRMdC8fB1adXSuLyNcF5Q4dKGpTuU6I76VAbDhcswKG7j0P3AIfuIQ7dIzF0t4O3lOgRL6SE2qmUUJEZpEEcIjSEWDJbZq2+p354l3jLE7mZT6pGLhoQ8j6IcPVD88z2CGEfFvLTKM5slBDREW/1AFOgEb0RP6C0BppHfDdsJw/85nVUz/sWH7Z73LeXk4n6ad8eRDJaet0zgkxoDv1WBxk4YUtzGONlU0wPAsgiBErajkDRyBGcKXQkd7tTET3WUU/EyQ8TBBcnCH2cIAxwgjDECULOKVC/DqVYJOQUlGQRz40NLo0+pRWEMWz0fIlLCPywWInx0AWF8CRXMZ7SZNVEKOogasIiPmLwENjs0C6hrFOt38KIdQkVHkGqK01frIkEQFpmLbEz4UFW2ktCO9XxUEEbEC24c94R3ODnCDSRHYGWkEMdCGTBukBzCpZFRg15GKNdHKP7OEYPcIweEhgNIhclt8NzHaAwS+ndmLEZ/D4hOMMCY/JVwXBIyM00AStwMJKy3vYVVey3w8ftWnCF5k3dgsO0cFphAYRIztlZB80KAFoxsamA0MZpjThIwBzgChqvvWVIpArSHG8N4mmbCWzsqQDABddVOQLZYIcS7pH686kDgqDWc48kC6RtzkYyggZwPAJVLmDwCIA8wMV5QJ/gAbAkJWi550RCFsa/6W5TL1Ev9u63eOEVePJeocSdQp8rL1H/qioUxCyD29tgsQvT+/nLtcKY1Au7m9C7z/74/msGcat460eXwaf5s91idd+JbzsXib9RMBJ45Tff3m/8+Yvd2ovU91XL0W79wU9e314G6f116qWqf5Nu4ikwvHvqJR+8RCHmdp4mOwWGu0Xoe8k739uoHv4SeR9Cfzm/9cKt3/0ULLKnyWpXfbleBGqOBqqz3UvV3UwEp/ssXiuAzR6u+yxQW4zaWdSf3/ihAt54t30Yg18Sb/4yWu62qWo77PiJp5B1qWo99KfzZdO59ZJ19zJer3cKzu876pm3asRKiL7KH5UahGxIXy7nw0F/sliOxs6H6WzgDGfDmTP1hp7je/548mE2GkxGo/0bus769XaXRPPet/8DCemswN2vAQA= ```

SomeTroglodyte commented 1 year ago

And does the Mod Check page of the Options popup mark it clean with G&K selected as base? ~~Are those mod bits identical to what can be found online?~~ (oh was linked clear enough)

It has something to do with a ConsumesResources unique lacking a param[0] as I see it, not with the json excerpt you showed, which is why I'm certain modchecker will finger the cause...

SomeTroglodyte commented 1 year ago

Modcheck is mostly harmless - not obviously understandable how that triggers UnitActions.kt:490

Lasty's Kazakhstan's colors do not contrast enough - it is unreadable!
Suggested colors: 
        "outerColor": [0, 140, 170],
        "innerColor": [254, 233, 38],
Aleksandria's colors do not contrast enough - it is unreadable!
Suggested colors: 
        "outerColor": [255, 255, 255],
        "innerColor": [178, 131, 22],
Thuntopia's colors do not contrast enough - it is unreadable!
Suggested colors: 
        "outerColor": [143, 110, 100],
        "innerColor": [0, 53, 0],
VividVale's colors do not contrast enough - it is unreadable!
Suggested colors: 
        "outerColor": [27, 87, 16],
        "innerColor": [212, 141, 19],
Wonderful Commander's unique "Can construct [Citadel]" is deprecated as of 4.5.2, replace with "Can instantly construct a [Citadel] improvement <by consuming this unit>"
Reactor's unique "Can start an [8]-turn golden age" is deprecated as of 4.5.3, replace with "Empire enters a [8]-turn Golden Age <by consuming this unit>"
Reactor's unique "Can construct [Academy]" is deprecated as of 4.5.2, replace with "Can instantly construct a [Academy] improvement <by consuming this unit>"

SomeTroglodyte commented 1 year ago

Got it.

            val resourcesAvailable = improvement.uniqueObjects.none {
                it.isOfType(UniqueType.ConsumesResources) &&
                        (civResources[unique.params[1]] ?: 0) < unique.params[0].toInt()
            }

The improvement was just pulled from the param 0 of val unique, which is the ConstructImprovement one. Now it thinks to check the ConsumesResources uniques of the improvement - and still pulls the parameters of the unit's ConstructImprovement...

This code hasn't been touched in almost a year.. And the mistake goes back to #5129??? Wow.

This calls for a unit test. Which means I'm not going to invest the time - too distracted.

SomeTroglodyte commented 1 year ago

Nice leader portrait. But I'd gimp it to a transparent background, then add a glow... Arepa.zip ... and 200x200px is enough.

Caballero-Arepa commented 1 year ago

And does the Mod Check page of the Options popup mark it clean with G&K selected as base?

Yeah, I forgot to mention that. I love using the mod checker, its really great, and when I get a crash I try to read it and see if I can understand something, most of the times I can get an idea of the problem, but times like this one I didnt have a clue.

This code hasn't been touched in almost a year.. And the mistake goes back to #5129??? Wow.

Oh wow. Guess I'll make it be built over by turns and not instantly.

XD why does the improvements have to be always so rusty.

Nice leader portrait. But I'd gimp it to a transparent background, then add a glow...

Yeah, I know its ugly with tha white background, but I forgot to change it lol

... and 200x200px is enough.

Yeah, that mod is a mess of icon sizes xD

Thank you for your investigation

SomeTroglodyte commented 1 year ago

Oye amigo, ye debes saber como hablo a veces.. Don't take everything 100% seriously.

Guess I'll make it be built over by turns and not instantly

Well, it is a simple oversight bug, and fixable by using it in that lambda instead of the outer variable unique

yairm210 / Unciv

Mod bug: Crashes when selecting unit #8921