Regressions with Notifications

[SomeTroglodyte]

Click between

See [NotificationsScroll lines 105, 106 comment](https://github.com/yairm210/Unciv/blob/master/core/src/com/unciv/ui/screens/worldscreen/NotificationsScroll.kt#L105) - it was intended that the notifications log area would cover the underlying map for clicks entirely. Now you can select tiles - where the Category headers are. Or activate City buttons: https://user-images.githubusercontent.com/63000004/227808990-d6b7aca2-2ce6-491b-a7ec-55987fbd0595.mp4

Scroll under TileInfo

Back then I invested effort to make the Notifications continue _under_ the TileInfo Table, and then ensuring one could scroll up far enough to read them all.. Gone. Thing is, situations like this:  ...were not prevented by the old code, but were visually far less jarring. And it was a cool feature! My only mistake was - I should have let it go on to the buttom, behind the minimap too. Pulled 4.4.0 jar from old releases: https://user-images.githubusercontent.com/63000004/227809062-8a4a6c41-57f2-49b6-a4d6-969d8cbbecf2.mp4 Current master 4.5.13 compiled: https://user-images.githubusercontent.com/63000004/227809083-4cd7f67f-295d-4115-bfa6-62e7a1835a91.mp4

Black Stat icon

Automatically inserted icons for Stats were an issue for quite some time, later circumvented (actually a kludge but it works nicely) - same can't be said for the Production category: 

So, do we want to do anything about any of these?

[Gualdimar]

the Notifications continue under the TileInfo Table

I should have let it go on to the buttom, behind the minimap too.

Can you explain the point of this if you still can't read the notification until you scroll through the notification? When I'm playing on my phone, sometimes I want to hide notifications altogether so that they don't take up space on the screen.

[SomeTroglodyte]

No real point, just "visually far less jarring" - And yea more noticeable on scarce screen real estate, like a phone in portrait. All very minor, just collecting opinions 🧅 .

And for point three I have an idea...

[SomeTroglodyte]

Hey, you triggered a very old idea there with ability to turn off notifs - when I built the Widget that carries the tools in map editor (you can drag the handle and leave it wherever you want or click it to open/close fully - animated) - put the notifs on one, you could slide them in or out... But where to put the handle? On the left, as the Widget is now, it would disturb the nice transparend jagged edge it has now - and where else? Old idea. Now I'd say - phone just make the entire thing swipable and when fully closed hijack a few pixels from the map area for dragging it back. Same wouldn't feel nice or be intuituve on desktop however...

[SomeTroglodyte]

Point 3 is handled, and I could soon present a WIP looking cute (no not using that editor widget - just the ScrollPane it already is).