search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.02k stars 1.51k forks source link

Feature request: Hide bomb shelters when nuclear weapons are disabled #9487

Open marek22k opened 1 year ago

marek22k commented 1 year ago

Is your feature request related to a problem? Please describe. Hello,

currently I can - regardless of whether nuclear weapons are deactivated - build an air raid shelter.

Describe the solution you'd like An air-raid shelter - or any building that has only this unique - can only be built or is only displayed if nuclear weapons are activated.

SomeTroglodyte commented 1 year ago

I can even find // Todo nuclear weapon and spaceship enabling requires a rethink. in source ...

@yairm210 - change UniqueType.EnablesNuclearWeapons -> to UniqueType.EnablesNuclearWeapons, UniqueType.PopulationLossFromNukes -> in Building.kt line 485? Wouldn't fit Marek's "only this unique" suggestion...

yairm210 commented 1 year ago

@SomeTroglodyte We can add a similar line, but that also checks if there is only 1 unique on the building

SomeTroglodyte commented 1 year ago

I'm not having the "this solution is so right" feeling. What about remove fallout? Maybe an explicit "Hide when nuclear weapons are disabled" globally applicable unique?

And - did a Civ four Bomb shelter not offer no advantage against nuke attacks?

yairm210 commented 1 year ago

"hide when disabled" sounds good

CrsiX commented 1 year ago

And - did a Civ four Bomb shelter not offer no advantage against nuke attacks?

According to the wiki, they "reduce damage from nuclear attacks". Source

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

marek22k commented 3 months ago

Please do not clone. @github-actions

marek22k commented 3 months ago

Is there a way to disable the bot? It is just annoying.

The background is as follows: Bugs do not go away because they are closed. Wishes are also rather rare. And I often get emails from this stupid bot (not only from this repo). If this becomes more frequent, it is worthwhile for me to create an anti-stale bot.

yairm210 commented 3 months ago

Wishes are not rate, that's the entire reason I enabled it to begin with. We've gotten to 200 open issues. That's more than we can even keep track of. This is extremely intentional.

SeventhM commented 3 months ago

On topic, how do we not have a unique to disable stuff if nukes are disabled? Seems like most of the more optional start of game settings probably should has corresponding uniques

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

marek22k commented 2 weeks ago

Bump

marek22k commented 2 weeks ago

Is there a way to disable the bot? It is just annoying.

@github-actions You are still annoying.