search

yairm210 / Unciv

Open-source Android/Desktop remake of Civ V
Mozilla Public License 2.0
8.39k stars 1.57k forks source link

Feature request: add more topics #9534

Closed GrimPixel closed 1 year ago

GrimPixel commented 1 year ago

Is your feature request related to a problem? Please describe. There are few topics to distinguish the use of mods. It is hard to see what the mod does simply by their names

Describe the solution you'd like Add more topics, like “unciv-nations”, “unciv-religions”, “unciv-buildings”, “unciv-improvements”, “unciv-units”.

SomeTroglodyte commented 1 year ago

Und just who is preventing you from adding such a topic to your mod...?

yairm210 commented 1 year ago

@SomeTroglodyte They won't appear as filters and as texts in the button: image

I think this is a good idea, as well as replacing "fun" with "mechanics" since that's what it's actually being used for practically speaking

SomeTroglodyte commented 1 year ago

Oh my, those really are hardcoded...

SomeTroglodyte commented 1 year ago

One could query them easily enough... https://api.github.com/search/topics?q=unciv-mod+repositories:%3E1&sort=name&order=asc

SomeTroglodyte commented 1 year ago

Live-queried: image

SomeTroglodyte commented 1 year ago

Also shows there's a communication problem - more people assign "unciv-mod-expansion" than they do "unciv-mod-expansions", which is the one that would work in the current master branch. Ahem, might work with some luck.

Also, the category filter author only checks against the second topic returned by the repo query, for no discernible reason, and afaik there is no documented guarantee of any order for that field, so the filter is hit and miss anyway (fixed in the branch that produced the screenie)...