Happiness improvement buildings take minutes when bying

[jujunantes]

Platform Android 13, 64bits.

Version 4.7.7, build 889.

Describe the bug When buying an happiness improvement building (tribunal, coliseum, theater, etc.) It now takes minutes of waiting before the game updates (the UI is not frozen it looks crashed but it isn't Eventually, the building is bought and the player can go on. It's like it takes ages to compute the happiness scores. Note that I have a huge map (75 SQ radius and hundred of cities). All the user buildings are built nearly instantly.

Expected behavior These buildings should be built as fast as any other building.

[yairm210]

Please attach a save file for example

[yairm210]

'hundereds of cities' if that's literally true, then it's possible this has no solution, since each of your cities now needs to update based on the new civ-wide happiness

[yairm210]

Unciv was never meant for that kind of scale

[SomeTroglodyte]

takes ages to compute the happiness scores

No it takes ages to optimize worker to tile assignments - when unhappiness blocks your growth it's best to move your workers away from the farms as the food is zeroed away anyway... It's also because of moddability - if that effect were hardcoded it would have been easier to optimize that step away when the happiness change does not cross one of the thresholds.

[SomeTroglodyte]

now takes minutes

And, ah yes, looking at the "before" to your "now" - back then cities would start starving needlessly because without re-evaluation of city focus the workers stayed off the farms despite improved happiness no longer zeroing food "upwards". A simple search turns that history up easily: https://github.com/yairm210/Unciv/issues?q=is%3Aissue+is%3Aclosed+starving

[jujunantes]

Please attach a save file for example

Here's my latest auto save. . For instance, try to buy a colloseum for New Avignon (the latest founded city). It takes about 3mn on my Redmi Note 10S.

There is a little bit less than 150 cities on the map.

[SeventhM]

I'm getting an warning from my browser trying to download that save. Can you upload that somewhere else, such as just attaching it to a message here?

[SomeTroglodyte]

warning

Only? With that <censored/> site loading code from only seven malware domains, that almost sound harmless. There are spam free open file hosters.

[SeventhM]

To be fair "warning" does downplay a big red screen not allowing me to even download it. But I'd assume things have to be really bad is the browser is warning

[jujunantes]

@all Sorry, I first uploaded my savegame from my mobile phone's browser, where the drag'n drop isn't available in Github's interface, so I used an external file hosting site. Here it is again, attached. Autosave.zip My Redmi Note 10S has a MediaTek Helio G95 CPU, which according to this website, can deliver nearly 200 GFLOPS. So, 3 minutes of computing represent about 36 000 GFLOPS. This seems like an awful lot of computing... :)

[SeventhM]

Redmi Note 10S

No offense, but this seems like a lowish tier phone from 2 years ago trying to calculate a game with 142 cities. Significantly better than a potato phone or one from 5+ years ago, but Idk how you even managed to finish the game. My phone crashes when reloading the game or when switching off the app

If we wanted to fix this, it looks like this is memory bounded, not cpu bounded, so I do imagine maybe it could be investigated. But games of this size is well beyond what's expected

[yairm210]

Solved!!! I knew we had an issue for this somewhere