yajatyadav / spring_portfolio

Tri 1: Java and Spring Intro
1 stars 0 forks source link

10/12 Crossover Team Grading #54

Open florayuan18 opened 3 years ago

abhijay-deevi commented 3 years ago

Hey, Hey, Hey!!! p1-slackbots the mega pro group back at it again with some grading!

View/Frontend - They are able to do the grayscale for all their images. Looks like they are able to use all the methods and show those in different donut images. 1/1

Control Improvement - Looks like everything is good here as well. They showed us our code and it looks like they have everything. We also looked through all their different sub-files and saw all the proper code. 1/1

Model Improvement - They have everything that is required. They have those lists, images, properties, and RGB attributes that were required on the canvas page. One thing that they could do better is the decimals and proper operations (-0.5) 2.5/3

Unit 7 CB Scores and Journals - They have the Tech Talk Notes, CB Scores and reflections, and extra notes in their journals. 3/3

Looks like the commits were a little low on some of them. -0.25 for the people that didn't really work on the code that much.

Great job guys! Everything looks good!

Harry Li - 7.5/8

Devam Shrivastava - 7.25/8

Flora Yuan - 7.5/8

Yajat Yadav - 7.5/8

Kyle Mint - 7.25/8

jm1021 commented 3 years ago

In video I saw DOS specific paths in program. This is not good! Does anyone have a Mac in team. Video cutoff and link was not in project. .50 off of everything. I probably should be taking a point. Also grader did not give anything significant in comments, NO LINK.

jm1021 commented 3 years ago

I was enjoying code review by Kyle, but it cutoff at 1:19.