yajiemiao / pdnn

PDNN: A Python Toolkit for Deep Learning. http://www.cs.cmu.edu/~ymiao/pdnntk.html
Apache License 2.0
224 stars 105 forks source link

delta_W_rec dimensions #19

Open eyaler opened 9 years ago

eyaler commented 9 years ago

in rnn, shouldn't: self.delta_W_rec = theano.shared(value = numpy.zeros((n_in,n_out), dtype=theano.config.floatX), name='delta_W_rec') be: self.delta_W_rec = theano.shared(value = numpy.zeros((n_out,n_out), dtype=theano.config.floatX), name='delta_W_rec') ?

ghost commented 9 years ago

The computation is T.dot(input, W), so the dimension is (n_in, n_out)

eyaler commented 9 years ago

not T.dot(h_tm1, self.W_rec) ?

ghost commented 9 years ago

"input" symbolically means inputs to a layer, not just the original features. It of course can refer to h_tm1