yajra / laravel-datatables-buttons

Laravel DataTables Buttons Plugin
https://yajrabox.com/docs/laravel-datatables/buttons-installation
MIT License
254 stars 53 forks source link

fix: use callback function if exportRender method is set #177

Closed mrezagolestan closed 1 year ago

mrezagolestan commented 1 year ago

this commit is paired with another commit d48dc1bbe8bc860070240d6f1444e7a861c53789 which should be pushed together to make final result:

this commit is about development not bug fix:

i realize a need to render column data for export, i found it by adding Export Class to set how to render export but i couldn't find any thing for render print and i need a centralized render for print & export (for simplicity & integrity) so i added exportRender method to be used for pass a callback function to determine how targeted column data should be rendered for print & export, sample code is shown below: Column::make('used')->title('Use Status')->exportRender(function($row,$data){return $data == 1 ? 'Yes' : 'Not Yet'});

but in this commit we write just use of callback function for rendering column to print or export as we expected but commit d48dc1bbe8bc860070240d6f1444e7a861c53789 in laravel-datatable-html repo should be pushed to exportRender method added to Column Builder for adding callback function

please accept that pull request before this pull request

mrezagolestan commented 1 year ago

195 pull request should be accept before this pull request

yajra commented 1 year ago

Can you also fix the failing checks here? Thanks!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mrezagolestan commented 1 year ago

why it hadn't merged ? i read PHPStan error & didn't get any idea for

yajra commented 1 year ago

Released in v10.0.7 🚀 Thanks!